From 51d607490cc964feeaa791756201d77e2f8126c8 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Wed, 16 Oct 2024 15:35:45 +0530 Subject: [PATCH 1/8] fix: CodeEditor - shebang className & styles --- src/Common/CodeEditor/CodeEditor.tsx | 2 +- src/Common/CodeEditor/codeEditor.scss | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Common/CodeEditor/CodeEditor.tsx b/src/Common/CodeEditor/CodeEditor.tsx index 417046283..90b3c62ff 100644 --- a/src/Common/CodeEditor/CodeEditor.tsx +++ b/src/Common/CodeEditor/CodeEditor.tsx @@ -348,7 +348,7 @@ const CodeEditor: React.FC & CodeEditorComposition = React. ) : ( <> - {shebang &&
{shebang}
} + {shebang &&
{shebang}
} {state.diffMode ? ( Date: Thu, 17 Oct 2024 17:27:06 +0530 Subject: [PATCH 2/8] chore: version bump --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 2ca44bac6..8a82dece7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-1", + "version": "0.5.2-beta-2", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-1", + "version": "0.5.2-beta-2", "license": "ISC", "dependencies": { "@types/react-dates": "^21.8.6", diff --git a/package.json b/package.json index 544ce8a4f..2718f2022 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-1", + "version": "0.5.2-beta-2", "description": "Supporting common component library", "type": "module", "main": "dist/index.js", From 3b41a3dc6c21211cc5c5364af49aa80788460ac1 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Fri, 18 Oct 2024 20:32:40 +0530 Subject: [PATCH 3/8] fix: DeploymentHistoryDiffView, DeploymentConfigDiff - UI issues fix --- .../DeploymentHistoryDiffView.tsx | 12 ++++++------ .../DeploymentHistoryConfigDiff/helpers.tsx | 2 +- src/Shared/Components/CICDHistory/cicdHistory.scss | 3 +-- .../DeploymentConfigDiff.component.tsx | 4 +++- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryDiffView.tsx b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryDiffView.tsx index e45d9950f..2a61026bc 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryDiffView.tsx +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryDiffView.tsx @@ -15,7 +15,7 @@ */ import { useParams } from 'react-router-dom' -import { Fragment, useMemo, useState } from 'react' +import { useMemo, useState } from 'react' import Tippy from '@tippyjs/react' import { yamlComparatorBySortOrder } from '@Shared/Helpers' import { MODES, Toggle, YAMLStringify } from '../../../../Common' @@ -111,11 +111,11 @@ const DeploymentHistoryDiffView = ({ singleValue: DeploymentHistorySingleValue, dataTestId: string, ) => ( -
-
+
+
{singleValue.displayName}
-
{singleValue.value}
+
{singleValue.value}
) @@ -150,7 +150,7 @@ const DeploymentHistoryDiffView = ({ const changeBGColor = previousConfigAvailable && currentValue?.value !== baseValue?.value return ( // eslint-disable-next-line react/no-array-index-key - +
{!isUnpublished && currentValue?.value ? ( renderDetailedValue( !isDeleteDraft && changeBGColor ? 'code-editor-red-diff' : '', @@ -169,7 +169,7 @@ const DeploymentHistoryDiffView = ({ ) : (
)} - +
) }, )} diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx index 140c8ecb8..86b9f9437 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx @@ -79,7 +79,7 @@ export const renderPipelineDeploymentOptionDescription = ({ }: Pick & Pick) => (
-

+

{stage} {artifact && ( diff --git a/src/Shared/Components/CICDHistory/cicdHistory.scss b/src/Shared/Components/CICDHistory/cicdHistory.scss index b552804ca..7df3367f4 100644 --- a/src/Shared/Components/CICDHistory/cicdHistory.scss +++ b/src/Shared/Components/CICDHistory/cicdHistory.scss @@ -114,8 +114,7 @@ .deployment-diff__upper { display: grid; - grid-template-columns: 50% 50%; - grid-template-rows: auto; + grid-template-columns: repeat(2, 1fr); position: relative; &::after { diff --git a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.component.tsx b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.component.tsx index 223354dbb..b12795bde 100644 --- a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.component.tsx +++ b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.component.tsx @@ -19,7 +19,9 @@ export const DeploymentConfigDiff = ({ renderedInDrawer, ...resProps }: DeploymentConfigDiffProps) => ( -

+
Date: Fri, 18 Oct 2024 21:15:18 +0530 Subject: [PATCH 4/8] fix: DeploymentHistory - incorrect runSource in deployments dropdown --- .../DeploymentHistoryConfigDiff.tsx | 3 +-- .../DeploymentHistoryConfigDiffCompare.tsx | 4 ++-- .../CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx | 4 ++-- .../CICDHistory/DeploymentHistoryConfigDiff/types.ts | 5 ++--- .../CICDHistory/DeploymentHistoryConfigDiff/utils.ts | 6 +++--- src/Shared/Components/CICDHistory/TriggerOutput.tsx | 1 - 6 files changed, 10 insertions(+), 13 deletions(-) diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiff.tsx b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiff.tsx index 104e2e2de..7dd13347a 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiff.tsx +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiff.tsx @@ -29,7 +29,6 @@ export const DeploymentHistoryConfigDiff = ({ wfrId, triggerHistory, setFullScreenView, - runSource, resourceId, renderRunSource, }: DeploymentHistoryConfigDiffProps) => { @@ -167,7 +166,7 @@ export const DeploymentHistoryConfigDiff = ({ setFullScreenView={setFullScreenView} convertVariables={convertVariables} setConvertVariables={setConvertVariables} - runSource={runSource} + triggerHistory={triggerHistory} resourceId={resourceId} renderRunSource={renderRunSource} hideDiffState={hideDiffState} diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiffCompare.tsx b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiffCompare.tsx index 7d23c80fb..7cde7eda3 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiffCompare.tsx +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/DeploymentHistoryConfigDiffCompare.tsx @@ -26,7 +26,7 @@ export const DeploymentHistoryConfigDiffCompare = ({ previousWfrId, convertVariables, setConvertVariables, - runSource, + triggerHistory, renderRunSource, resourceId, isCompareDeploymentConfigNotAvailable, @@ -60,7 +60,7 @@ export const DeploymentHistoryConfigDiffCompare = ({ const { currentDeployment, pipelineDeploymentsOptions } = getPipelineDeploymentsOptions({ pipelineDeployments, wfrId, - runSource, + triggerHistory, renderRunSource, resourceId, }) diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx index 86b9f9437..ca5b08981 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/helpers.tsx @@ -76,8 +76,8 @@ export const renderPipelineDeploymentOptionDescription = ({ renderRunSource, resourceId, runSource, -}: Pick & - Pick) => ( +}: Pick & + Pick) => (

{stage} diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/types.ts b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/types.ts index 350ed7d50..55f4bcbed 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/types.ts +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/types.ts @@ -3,7 +3,7 @@ import { Dispatch, SetStateAction } from 'react' import { DeploymentConfigDiffProps } from '@Shared/Components/DeploymentConfigDiff' import { EnvResourceType } from '@Shared/Services' -import { History, HistoryLogsProps, RunSourceType } from '../types' +import { History, HistoryLogsProps } from '../types' export interface DeploymentHistoryConfigDiffProps extends Required> { @@ -11,7 +11,6 @@ export interface DeploymentHistoryConfigDiffProps envName: string pipelineId: number wfrId: number - runSource: RunSourceType triggerHistory: Map setFullScreenView: (fullscreen: boolean) => void } @@ -23,7 +22,7 @@ export type DeploymentHistoryDiffDetailedProps = Pick< Required< Pick< DeploymentHistoryConfigDiffProps, - 'setFullScreenView' | 'wfrId' | 'envName' | 'renderRunSource' | 'resourceId' | 'runSource' + 'setFullScreenView' | 'wfrId' | 'envName' | 'renderRunSource' | 'resourceId' | 'triggerHistory' > > & { pipelineDeployments: History[] diff --git a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/utils.ts b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/utils.ts index 21a41d472..f3cc47d20 100644 --- a/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/utils.ts +++ b/src/Shared/Components/CICDHistory/DeploymentHistoryConfigDiff/utils.ts @@ -31,8 +31,8 @@ export const getPipelineDeploymentsOptions = ({ wfrId, renderRunSource, resourceId, - runSource, -}: Required> & { + triggerHistory, +}: Required> & { pipelineDeployments: History[] wfrId: number }) => { @@ -50,7 +50,7 @@ export const getPipelineDeploymentsOptions = ({ artifact, renderRunSource, resourceId, - runSource, + runSource: triggerHistory.get(id).runSource, }), startIcon: renderPipelineDeploymentStatusIcon(status), }), diff --git a/src/Shared/Components/CICDHistory/TriggerOutput.tsx b/src/Shared/Components/CICDHistory/TriggerOutput.tsx index 400c588ee..1113074dc 100644 --- a/src/Shared/Components/CICDHistory/TriggerOutput.tsx +++ b/src/Shared/Components/CICDHistory/TriggerOutput.tsx @@ -601,7 +601,6 @@ const HistoryLogs: React.FC = ({ setFullScreenView={setFullScreenView} resourceId={resourceId} renderRunSource={renderRunSource} - runSource={triggerDetails.runSource} /> )} From bb309f2add5787f3b8d4d7e60fae26a01039fc4b Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Fri, 18 Oct 2024 21:17:37 +0530 Subject: [PATCH 5/8] chore: version bump --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8a82dece7..3648ec9f4 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-2", + "version": "0.5.2-beta-7", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-2", + "version": "0.5.2-beta-7", "license": "ISC", "dependencies": { "@types/react-dates": "^21.8.6", diff --git a/package.json b/package.json index 2718f2022..ecccc60f9 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-2", + "version": "0.5.2-beta-7", "description": "Supporting common component library", "type": "module", "main": "dist/index.js", From d1ff7202d507cca33a1ce057bf4af29f22d48cc9 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Mon, 21 Oct 2024 13:34:08 +0530 Subject: [PATCH 6/8] feat: DeploymentConfigDiff - revamped logic to parse draft deployment template resolved values and template version --- .../DeploymentConfigDiff.types.ts | 5 ++ .../DeploymentConfigDiff.utils.tsx | 78 ++++++++++++++----- 2 files changed, 64 insertions(+), 19 deletions(-) diff --git a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.types.ts b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.types.ts index 040cd05d1..f23f7d9c8 100644 --- a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.types.ts +++ b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.types.ts @@ -5,6 +5,7 @@ import { ConfigMapSecretDataConfigDatumDTO, DeploymentTemplateDTO, EnvResourceType, + TemplateListDTO, } from '@Shared/Services' import { ManifestTemplateDTO } from '@Pages/Applications' @@ -152,10 +153,14 @@ export type AppEnvDeploymentConfigListParams = (IsManifestView e ? { currentList: ManifestTemplateDTO compareList: ManifestTemplateDTO + compareToTemplateOptions?: never + compareWithTemplateOptions?: never } : { currentList: AppEnvDeploymentConfigDTO compareList: AppEnvDeploymentConfigDTO + compareToTemplateOptions?: TemplateListDTO[] + compareWithTemplateOptions?: TemplateListDTO[] }) & { getNavItemHref: (resourceType: EnvResourceType, resourceName: string) => string isManifestView?: IsManifestView diff --git a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx index dfe81af04..9329419b3 100644 --- a/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx +++ b/src/Shared/Components/DeploymentConfigDiff/DeploymentConfigDiff.utils.tsx @@ -40,6 +40,22 @@ export const getDeploymentTemplateData = (data: DeploymentTemplateDTO) => { ) } +const getDeploymentTemplateAppMetricsAndTemplateVersion = ( + data: DeploymentTemplateDTO, + templateOptions: TemplateListDTO[], +) => { + const parsedDraftData = JSON.parse(data?.deploymentDraftData?.configData[0].draftMetadata.data || null) + const draftTemplateVersion = templateOptions?.find( + ({ chartRefId }) => parsedDraftData?.chartRefId === chartRefId, + )?.chartVersion + + return { + isAppMetricsEnabled: + parsedDraftData || data ? parsedDraftData?.isAppMetricsEnabled || data?.isAppMetricsEnabled || false : null, + templateVersion: draftTemplateVersion || data?.templateVersion, + } +} + /** * Retrieves the draft data from the given configuration data object. * @@ -338,7 +354,7 @@ const getDiffViewData = ( } } -const getDeploymentTemplateDiffViewData = (data: DeploymentTemplateDTO | null) => { +const getDeploymentTemplateDiffViewData = (data: DeploymentTemplateDTO | null, templateOptions: TemplateListDTO[]) => { const _data = getDeploymentTemplateData(data) const codeEditorValue = { displayName: 'data', @@ -347,8 +363,7 @@ const getDeploymentTemplateDiffViewData = (data: DeploymentTemplateDTO | null) = const diffViewData = prepareHistoryData( { - ...(data || {}), - isAppMetricsEnabled: data ? data.isAppMetricsEnabled || false : null, + ...getDeploymentTemplateAppMetricsAndTemplateVersion(data, templateOptions), codeEditorValue, }, DEPLOYMENT_HISTORY_CONFIGURATION_LIST_MAP.DEPLOYMENT_TEMPLATE.VALUE, @@ -516,12 +531,39 @@ const getConfigMapSecretData = ( return deploymentConfig } -const getDeploymentTemplateResolvedData = (deploymentTemplate: DeploymentTemplateDTO) => { +const getDeploymentTemplateResolvedData = (deploymentTemplate: DeploymentTemplateDTO): DeploymentTemplateDTO => { try { if (deploymentTemplate.deploymentDraftData) { - return JSON.parse(deploymentTemplate.deploymentDraftData.configData[0].draftMetadata.draftResolvedValue) + const parsedDraftResolvedData = JSON.parse( + deploymentTemplate.deploymentDraftData.configData[0].draftMetadata.draftResolvedValue, + ) + + return { + ...deploymentTemplate, + deploymentDraftData: { + ...deploymentTemplate.deploymentDraftData, + configData: [ + { + ...deploymentTemplate.deploymentDraftData.configData[0], + draftMetadata: { + ...deploymentTemplate.deploymentDraftData.configData[0].draftMetadata, + data: JSON.stringify({ + ...JSON.parse( + deploymentTemplate.deploymentDraftData.configData[0].draftMetadata.data, + ), + envOverrideValues: parsedDraftResolvedData, + }), + }, + }, + ], + }, + } + } + + return { + ...deploymentTemplate, + data: deploymentTemplate.resolvedValue, } - return deploymentTemplate.resolvedValue } catch { return null } @@ -545,19 +587,9 @@ const getConfigDataWithResolvedDeploymentTemplate = ( return data } - const deploymentTemplateResolvedData = getDeploymentTemplateResolvedData(data.deploymentTemplate) - return { ...data, - deploymentTemplate: { - ...data.deploymentTemplate, - ...(deploymentTemplateResolvedData - ? { - data: deploymentTemplateResolvedData, - deploymentDraftData: null, - } - : {}), - }, + deploymentTemplate: getDeploymentTemplateResolvedData(data.deploymentTemplate), } } @@ -579,6 +611,8 @@ export const getAppEnvDeploymentConfigList = ): { configList: DeploymentConfigDiffProps['configList'] navList: DeploymentConfigDiffProps['navList'] @@ -593,8 +627,14 @@ export const getAppEnvDeploymentConfigList = ['compareList'], convertVariables, ) - const currentDeploymentData = getDeploymentTemplateDiffViewData(compareToObject.deploymentTemplate) - const compareDeploymentData = getDeploymentTemplateDiffViewData(compareWithObject.deploymentTemplate) + const currentDeploymentData = getDeploymentTemplateDiffViewData( + compareToObject.deploymentTemplate, + compareToTemplateOptions, + ) + const compareDeploymentData = getDeploymentTemplateDiffViewData( + compareWithObject.deploymentTemplate, + compareWithTemplateOptions, + ) const deploymentTemplateData = { id: EnvResourceType.DeploymentTemplate, From 4a8f0dcefa4d1c56db671071d0b87f25b6d2e8b7 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Mon, 21 Oct 2024 13:35:09 +0530 Subject: [PATCH 7/8] chore: version bump --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3648ec9f4..355a02062 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-7", + "version": "0.5.2-beta-8", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-7", + "version": "0.5.2-beta-8", "license": "ISC", "dependencies": { "@types/react-dates": "^21.8.6", diff --git a/package.json b/package.json index ecccc60f9..bc9fef17f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.2-beta-7", + "version": "0.5.2-beta-8", "description": "Supporting common component library", "type": "module", "main": "dist/index.js", From 48676aab78891f8e00924a721709b1df9e98b491 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Mon, 21 Oct 2024 15:31:56 +0530 Subject: [PATCH 8/8] chore: version bump --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 5061cdddc..7949e2738 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.4", + "version": "0.5.5", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.4", + "version": "0.5.5", "license": "ISC", "dependencies": { "@types/react-dates": "^21.8.6", diff --git a/package.json b/package.json index d49a4547f..7187cd005 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@devtron-labs/devtron-fe-common-lib", - "version": "0.5.4", + "version": "0.5.5", "description": "Supporting common component library", "type": "module", "main": "dist/index.js",