Merge pull request #347 from devtron-labs/chore/dev-sync-v20

chore: dev sync v20

Author: eshankvaish

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@devtron-labs/devtron-fe-common-lib",
-    "version": "4.0.2",
+    "version": "0.5.0",
     "description": "Supporting common component library",
     "type": "module",
     "main": "dist/index.js",

package.json

@@ -166,7 +166,7 @@ export const parseSchemaHiddenType = (hiddenSchema: HiddenType): MetaHiddenType
     const clone = structuredClone(hiddenSchema)
     if (typeof clone === 'string') {
         return {
-            value: false,
+            value: true,
             path: conformPathToPointers(clone),
         }
     }

src/Common/RJSF/utils.tsx

@@ -110,8 +110,8 @@ const DateTimePicker = ({
                             onChange={handleTimeChange}
                             data-testid={dataTestIdForTime}
                             menuSize={ComponentSizeType.xs}
-                            menuPosition="absolute"
                             size={ComponentSizeType.large}
+                            shouldMenuAlignRight
                         />
                     </div>
                 )}

src/Shared/Components/DatePicker/DateTimePicker.tsx

@@ -14,7 +14,6 @@
  * limitations under the License.
  */
 
-import { ReactComponent as ErrorIcon } from '@Icons/ic-warning.svg'
 import { ReactComponent as ClockIcon } from '@Icons/ic-clock.svg'
 import { ComponentSizeType } from '@Shared/constants'
 import { DEFAULT_TIME_OPTIONS } from './utils'
@@ -29,26 +28,18 @@ export const TimePickerSelect = ({
     error,
     selectedTimeOption,
 }: TimeSelectProps) => (
-    <>
-        <SelectPicker
-            inputId={DATE_PICKER_IDS.TIME}
-            placeholder="12:00 AM"
-            options={DEFAULT_TIME_OPTIONS}
-            isSearchable={false}
-            isDisabled={disabled}
-            {...timePickerProps}
-            value={selectedTimeOption}
-            icon={<ClockIcon className="icon-dim-20 fcn-6" />}
-            onChange={onChange}
-            data-testid={DATE_PICKER_IDS.TIME}
-            size={ComponentSizeType.large}
-            menuPosition="absolute"
-        />
-        {error && (
-            <div className="form__error">
-                <ErrorIcon className="form__icon form__icon--error" />
-                {error}
-            </div>
-        )}
-    </>
+    <SelectPicker
+        inputId={DATE_PICKER_IDS.TIME}
+        placeholder="12:00 AM"
+        options={DEFAULT_TIME_OPTIONS}
+        isSearchable={false}
+        isDisabled={disabled}
+        {...timePickerProps}
+        value={selectedTimeOption}
+        icon={<ClockIcon className="icon-dim-20 fcn-6" />}
+        onChange={onChange}
+        data-testid={DATE_PICKER_IDS.TIME}
+        size={ComponentSizeType.large}
+        error={error}
+    />
 )

src/Shared/Components/DatePicker/TimeSelect.tsx

@@ -69,7 +69,7 @@
     &__close-btn {
         button {
             svg {
-                use {
+                path {
                     fill: var(--N0) !important;
                 }
             }