chore: code refactoring

Author: shivani170

src/Shared/Hooks/useUserPreferences/constants.ts

@@ -14,8 +14,4 @@
  * limitations under the License.
  */
 
-import { ResourceKindType } from '@Shared/index'
-
 export const USER_PREFERENCES_ATTRIBUTE_KEY = 'userPreferences'
-
-export const UserPreferenceResourceKeys: ResourceKindType[] = [ResourceKindType.devtronApplication]

src/Shared/Hooks/useUserPreferences/service.ts

@@ -30,7 +30,7 @@ import {
     UserPathValueMapType,
     UserPreferenceResourceProps,
 } from './types'
-import { getUserPreferenceResourcesMetaData } from './utils'
+import { getUserPreferenceResourcesMetadata } from './utils'
 
 /**
  * @returns UserPreferencesType
@@ -100,7 +100,7 @@ const getUserPreferencePayload = async ({
 
         case 'resources':
             return {
-                resources: getUserPreferenceResourcesMetaData(value as BaseAppMetaData[]),
+                resources: getUserPreferenceResourcesMetadata(value as BaseAppMetaData[]),
             }
         default:
             return {}

src/Shared/Hooks/useUserPreferences/utils.tsx

@@ -1,13 +1,14 @@
-import { BaseAppMetaData, ResourceKindType, UserPreferenceResourceKeys } from '@Shared/index'
+import { BaseAppMetaData, ResourceKindType } from '@Shared/index'
 import { UserPreferenceFilteredListTypes, UserPreferenceResourceActions, UserPreferenceResourceType } from './types'
 
-export const getUserPreferenceResourcesMetaData = (recentlyVisited: BaseAppMetaData[]): UserPreferenceResourceType =>
-    UserPreferenceResourceKeys.reduce((acc, resource) => {
-        acc[resource] = {
-            [UserPreferenceResourceActions.RECENTLY_VISITED]: recentlyVisited,
-        }
-        return acc
-    }, {} as UserPreferenceResourceType)
+export const getUserPreferenceResourcesMetadata = (recentlyVisited: BaseAppMetaData[]): UserPreferenceResourceType => ({
+    [ResourceKindType.devtronApplication]: {
+        [UserPreferenceResourceActions.RECENTLY_VISITED]: recentlyVisited.map(({ appId, appName }) => ({
+            appId,
+            appName,
+        })),
+    },
+})
 
 export const getFilteredUniqueAppList = ({
     userPreferencesResponse,
@@ -29,6 +30,5 @@ export const getFilteredUniqueAppList = ({
         ...validApps.filter((app) => app.appId !== appId), // Keep previous order, remove duplicate
     ].slice(0, 6) // Limit to 6 items
 
-    const uniqueFilteredApps = isInvalidAppId ? uniqueApps.filter((app) => app.appId !== Number(appId)) : uniqueApps
-    return uniqueFilteredApps
+    return isInvalidAppId ? uniqueApps.filter((app) => app.appId !== Number(appId)) : uniqueApps
 }