Skip to content

Commit c6e0e59

Browse files
committed
feat: add fallbackString param to getTimeDifference and move its params into object
1 parent 7ae0502 commit c6e0e59

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

src/Shared/Components/CICDHistory/LogStageAccordion.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ const LogStageAccordion = ({
5151
}
5252

5353
const getFormattedTimeDifference = (): string => {
54-
const timeDifference = getTimeDifference(startTime, endTime)
54+
const timeDifference = getTimeDifference({ startTime, endTime })
5555
if (timeDifference === '0s') {
5656
return '< 1s'
5757
}

src/Shared/Helpers.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ import {
5151
import {
5252
AggregationKeys,
5353
BorderConfigType,
54+
GetTimeDifferenceParamsType,
5455
GitTriggers,
5556
IntersectionChangeHandler,
5657
IntersectionOptions,
@@ -778,9 +779,13 @@ export const decode = (data, isEncoded: boolean = false) =>
778779

779780
export const isTimeStringAvailable = (time: string): boolean => !!time && time !== ZERO_TIME_STRING
780781

781-
export const getTimeDifference = (startTime: string, endTime: string): string => {
782+
export const getTimeDifference = ({
783+
startTime,
784+
endTime,
785+
fallbackString = '-',
786+
}: GetTimeDifferenceParamsType): string => {
782787
if (!isTimeStringAvailable(startTime) || !isTimeStringAvailable(endTime)) {
783-
return '-'
788+
return fallbackString
784789
}
785790

786791
const seconds = moment(endTime).diff(moment(startTime), 'seconds')

src/Shared/types.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1134,3 +1134,12 @@ export type IconBaseColorType =
11341134
| 'white'
11351135
| 'black'
11361136
| null
1137+
1138+
export interface GetTimeDifferenceParamsType {
1139+
startTime: string
1140+
endTime: string
1141+
/**
1142+
* @default '-'
1143+
*/
1144+
fallbackString?: string
1145+
}

0 commit comments

Comments
 (0)