Skip to content

Commit 2994ec0

Browse files
committed
chore: Remove isMandatory property from StepType interface
1 parent 64d65f8 commit 2994ec0

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

src/Common/CIPipeline.Types.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ export interface StepType {
170170
inlineStepDetail?: InlineStepDetailType
171171
pluginRefStepDetail?: PluginRefStepDetailType
172172
triggerIfParentStageFail: boolean
173-
isMandatory?: boolean
174173
}
175174

176175
export interface BuildStageType {

src/Common/Policy.Types.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
import { PluginDataStoreType, PluginDetailPayloadType } from '../Shared'
17+
import { PluginDataStoreType, PluginDetailPayloadType, ResourceKindType } from '../Shared'
1818
import { FormType, VariableType } from './CIPipeline.Types'
1919
import { ServerErrors } from './ServerError'
2020
import { ResponseType } from './Types'
@@ -27,10 +27,11 @@ export enum ApplyPolicyToStage {
2727
PRE_CD = 'PRE_CD',
2828
}
2929

30+
// This enum is mapping values from BuildStageVariable
3031
export enum PluginRequiredStage {
31-
PRE_CI = 'preBuildStage',
32-
POST_CI = 'postBuildStage',
33-
PRE_OR_POST_CI = 'PRE_OR_POST_CI',
32+
PRE_STAGE = 'preBuildStage',
33+
POST_STAGE = 'postBuildStage',
34+
PRE_OR_POST_STAGE = 'PRE_OR_POST_CI',
3435
}
3536

3637
export interface DefinitionSourceType {
@@ -63,6 +64,7 @@ export interface ProcessPluginDataReturnType {
6364
}
6465

6566
export type ProcessPluginDataCIParamsType = {
67+
resourceKind: ResourceKindType.ciPipeline
6668
ciPipelineId: number
6769
/**
6870
* Comma separated branch names used for v1 api
@@ -75,6 +77,7 @@ export type ProcessPluginDataCIParamsType = {
7577
}
7678

7779
export type ProcessPluginDataCDParamsType = {
80+
resourceKind: ResourceKindType.cdPipeline
7881
cdPipelineId: number
7982
envName?: string
8083

src/Shared/Components/InfoIconTippy/InfoIconTippy.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,11 @@ const InfoIconTippy = ({
3030
placement = 'bottom',
3131
dataTestid = 'info-tippy-button',
3232
children,
33+
headingInfo,
3334
}: InfoIconTippyProps) => (
3435
<TippyCustomized
3536
theme={TippyTheme.white}
37+
headingInfo={headingInfo}
3638
className="w-300 h-100 dc__no-text-transform"
3739
placement={placement}
3840
Icon={HelpIcon}

0 commit comments

Comments
 (0)