Skip to content

OMPI: Notified RMA ops Public API #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joe-explr wants to merge 1 commit into
base: notified-rma
Choose a base branch
from
Open

OMPI: Notified RMA ops Public API #9

joe-explr wants to merge 1 commit into from

Conversation

@joe-explr
Copy link

@joe-explr joe-explr commented Nov 19, 2025 •
edited
Loading

Summary of Changes:

  • Created a new files: put_with_notify.c.in, get_with_notify.c.in. to enable a public api for put_with_notify and get_with_notify.
  • Added OMPI_SPC_GET_WITH_NOTIFY, OMPI_SPC_PUT_WITH_NOTIFY enum to track call counts.
  • Added 'MPI_ERR_NOTIFY_IDX' to error out invalid notification_idx value.
  • Edited mpi.h.in to add definitions for the ERROR and the operation signature.

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8d7ea3b: Public APis to makefile

  • check_signed_off: does not contain a valid Signed-off-by line

0b6b3c3: Public APIs for put_withnotify. get_with_notify

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@joe-explr joe-explr force-pushed the notified-rma-sm branch 3 times, most recently from 5a9c010 to f79b94b Compare November 19, 2025 19:28
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8ba738e: Edits

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

devreal
devreal approved these changes Nov 20, 2025
View reviewed changes
ompi/mpi/c/get_with_notify.c.in Outdated
#include "ompi/datatype/ompi_datatype.h"
#include "ompi/runtime/ompi_spc.h"

PROTOTYPE ERROR_CLASS get_with_notify(BUFFER_OUT origin_addr, COUNT origin_count,
Copy link
Owner

@devreal devreal Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be consistent with the proposal (get_notify).

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

Hello! The Git Commit Checker CI bot found a few problems with this PR:

dff9ea5: Public APIs for:

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@joe-explr
Public APIs for:
6519bd0 
	put_with_notify
	get_with_notify

Signed-off-by: Joseph Antony <jajoseph.antony18@gmail.com>
joe-explr
joe-explr commented Dec 5, 2025
View reviewed changes
ompi/mca/osc/sm/osc_sm.h
int ompi_osc_sm_free(struct ompi_win_t *win);

// TODO: add put/get_with_notify prototypes
// TODO: add put/get_notify prototypes
Copy link
Author

@joe-explr joe-explr Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Will remove todos

joe-explr
joe-explr commented Dec 5, 2025
View reviewed changes
ompi/runtime/ompi_spc.c
SET_COUNTER_ARRAY(OMPI_SPC_PUT_NOTIFY, "The number of times MPI_Put_notify was called.", false, false),
SET_COUNTER_ARRAY(OMPI_SPC_RPUT, "The number of times MPI_Rput was called.", false, false),
SET_COUNTER_ARRAY(OMPI_SPC_GET, "The number of times MPI_Get was called.", false, false),
SET_COUNTER_ARRAY(OMPI_SPC_GET_NOTIFY, "The number of times MPI_Get was called.", false, false),
Copy link
Author

@joe-explr joe-explr Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The number of times MPI_Get_notify was called, will fix the error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devreal devreal devreal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joe-explr @devreal