More refactoring of registry related code, add simple test

Author: pysysops

pkg/xterrafile/registry.go

@@ -50,11 +50,11 @@ func GetRegistrySource(name string, source string, version string, services *dis
 
 	version, err = getRegistryVersion(regClient, modSrc, version)
 	CheckIfError(name, err)
-
 	jww.INFO.Printf("[%s] Found module version %s at %s", name, version, modSrc.Host())
 
 	regSrc, err := regClient.ModuleLocation(modSrc, version)
 	CheckIfError(name, err)
+	jww.INFO.Printf("[%s] Downloading from source URL %s", name, regSrc)
 
 	return regSrc
 }

pkg/xterrafile/registry_test.go

@@ -23,7 +23,11 @@ func TestIsRegistrySourceAddr(t *testing.T) {
 }
 
 func TestGetRegistrySource(t *testing.T) {
+	server := test.Registry()
+	defer server.Close()
 
+	module1Src := GetRegistrySource("droplet", "example.com/test-versions/name/provider", "2.1.x", test.Disco(server))
+	assert.IsType(t, "string", module1Src, "download URL should be a string")
 }
 
 func TestGetModSrc(t *testing.T) {