Push to get basic tests operational.

Author: apolloakora

README.md

@@ -22,27 +22,37 @@ You specify every ingress rule you need in just one line with words like **ssh**
         vpc_security_group_ids = "${module.security_group.out_security_group_ids}"
     }
 
-
 Output **out_security_group_ids** is a **list** whilst **out_security_group_id** is a **string**.
 
 ## [Examples and Tests](test-security.group)
 
 **[This terraform module has runnable example integration tests](test-security.group)**. Read the instructions on how to clone the project and run the integration tests.
 
 
-## Security Group Module Inputs
+## Use Case
+
+What is the use case flow at the heart of this security group rule creation module?
+
+- a **VPC is provided** (or the default one is used)
+- a **security group is created** (or the default one for the VPC is used)
+- **ingress and egress rules are added to the security group**
+- the default source (and/or destination) of 0.0.0.0/0 is used
+- the rules can apply to specific supplied (source and/or destination) addresses
+
+
+## Inputs
 
 The security group's input variables are vital to achieving the desired behaviour.
 
 | Imported | Type | Default | Comment |
 |:-------- |:---- |:------- |:------- |
 **in_vpc_id** | String | vpc-1234567890 | create security group/s under VPC with this id
 **in_use_default** | Boolean | [ true ] | use the default security group if true else create one
-**in_ingress** | List | [ "postgres", "https"] | identigy the ports to allow for inbound traffic
-**in_egress** | List | [ "all-traffic" ] | identigy the ports to allow for outbound traffic
+**in_ingress** | List | [ "postgres", "https"] | identify the ports to allow for inbound traffic
+**in_egress** | List | [ "all-traffic" ] | identify the ports to allow for outbound traffic
 **in_ingress_cidr_blocks** | List | [ "0.0.0.0/0"] | list of source incoming traffic addresses to allow
 **in_egress_cidr_blocks** | List | [ "0.0.0.0/0"] | list of VPC source outgoing traffic addresses to allow
-**in_ecosystem_id** | String | kube-19188-2306 | the ecosystem's identifier including a timestamp
+**in_ecosystem** | String | kube-19188-2306 | the ecosystem's identifier including a timestamp
 
 ## Alternate Module Inputs
 

test-security.group/README.md

@@ -1,25 +1,30 @@
 
-# Test the AWS VPC Subnets Module
+# Integration Tests | Security Group Rules Terraform Module
 
-You can unit test the [[terraform-aws-vpc-subnets module]](https://github.com/devops-ip/terraform-aws-vpc-subnets) which **creates VPCs subnets in a round robin** manner.
+You can [run the integration tests](security.group-test.tf) that are biased towards creating security group rules.
 
-    $ git clone https://github.com/devops-ip/test-vpc-subnets.git
-    $ cd test-vpc-subnets
+So what happens at the core of the security group integration tests?
+
+- a **VPC is provided** (or the default one is used)
+- a **security group is created** (or the default one for the VPC is used)
+- **ingress and egress rules are added to the security group**
+- the default source (and/or destination) of 0.0.0.0/0 is used
+- the rules can apply to specific supplied (source and/or destination) addresses
+
+## How to Run the Integration Tests
+
+    $ git clone https://github.com/devops-ip/terraform-aws-security-group.git
+    $ cd terraform-aws-security-group
     $ terraform init .
     $ terraform apply -auto-approve
     $ terraform destroy -auto-approve
 
-## Unit Test Pre-Conditions
+## Integration Test Pre-Conditions
 
 Check before you run the test that
 
 - terraform and git are installed
 - you have created an AWS IAM user with VPC permissions
-- your [[AWS credentials have been installed]](https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/setup-credentials.html)
-- headroom exists for 10 more VPCs
-
-## Extend the 5 VPC Limit
-
-The default VPC limit is a pithy 5 and we need at least 10 to test all the functionality in this ubiquitous VPC/Subnet creation module.
+- your [AWS credentials have been installed](https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/setup-credentials.html)
+- headroom exists for a couple more (temporary) VPCs
 
-On receiving your support ticket AWS automatically ups the VPC limit if you request 25 or less.

test-security.group/security.group-test.tf

@@ -5,29 +5,37 @@
 
 locals
 {
-    ecosystem_id = "vs-unittest"
+    ecosystem_id = "sgrules-test"
+}
+
+module vpc-subnets
+{
+    source       = "github.com/devops-ip/terraform-aws-vpc-subnets"
+    in_vpc_cidr  = "10.123.45.0/16"
+    in_ecosystem = "${local.ecosystem_id}"
 }
 
 module zero-param-test
 {
-    source = "github.com/devops-ip/terraform-aws-vpc-subnets"
+    source = "github.com/devops-ip/terraform-aws-security-group
 }
 
 module last-stable-release-test-0
 {
-    source       = "github.com/devops-ip/terraform-aws-vpc-subnets?ref=v0.1.0002"
-    in_vpc_cidr  = "10.234.56.0/24"
+    source       = "github.com/devops-ip/terraform-aws-security-group?ref=v0.1.0001"
+    in_ingress   = [ "ssh", "http", "https" ]
     in_ecosystem = "${local.ecosystem_id}-00"
 }
 
-module vpc-subnets-test-1
+module security-group-test-1
 {
-    source       = "github.com/devops-ip/terraform-aws-vpc-subnets"
-    version      = "v0.1.0002"
-    in_vpc_cidr  = "10.234.0.0/16"
+    source       = "github.com/devops-ip/terraform-aws-security-group"
+    version      = "v0.1.0001"
+    in_vpc_id    = "${module.vpc-subnets.out_vpc_id}"
     in_ecosystem = "${local.ecosystem_id}-01"
 }
 
+/*
 module vpc-subnets-test-2
 {
     source         =  "github.com/devops-ip/terraform-aws-vpc-subnets"
@@ -99,18 +107,12 @@ module vpc-subnets-test-9
     in_ecosystem           = "${local.ecosystem_id}-09"
 }
 
-output subnet_ids_1{ value = "${module.vpc-subnets-test-1.out_subnet_ids}" }
-output private_subnet_ids_1{ value = "${module.vpc-subnets-test-1.out_private_subnet_ids}" }
-output public_subnet_ids_1{ value = "${module.vpc-subnets-test-1.out_public_subnet_ids}" }
+*/
 
-output subnet_ids_2{ value = "${module.vpc-subnets-test-6.out_subnet_ids}" }
-output private_subnet_ids_2{ value = "${module.vpc-subnets-test-6.out_private_subnet_ids}" }
-output public_subnet_ids_2{ value = "${module.vpc-subnets-test-6.out_public_subnet_ids}" }
 
-output subnet_ids_3{ value = "${module.vpc-subnets-test-7.out_subnet_ids}" }
-output private_subnet_ids_3{ value = "${module.vpc-subnets-test-7.out_private_subnet_ids}" }
-output public_subnet_ids_3{ value = "${module.vpc-subnets-test-7.out_public_subnet_ids}" }
+output subnet_ids_1{ value = "${module.vpc-subnets.out_subnet_ids}" }
+output private_subnet_ids_1{ value = "${module.vpc-subnets.out_private_subnet_ids}" }
+output public_subnet_ids_1{ value = "${module.vpc-subnets.out_public_subnet_ids}" }
 
-output subnet_ids_4{ value = "${module.vpc-subnets-test-9.out_subnet_ids}" }
-output private_subnet_ids_4{ value = "${module.vpc-subnets-test-9.out_private_subnet_ids}" }
-output public_subnet_ids_4{ value = "${module.vpc-subnets-test-9.out_public_subnet_ids}" }
+output security_group_id_1 { value = "${module.security-group-test-1.out_security_group_id}"  }
+output security_group_ids_1{ value = "${module.security-group-test-1.out_security_group_ids}" }