Separate LB resource into application and network resources

Author: Steven Nemetz

main.tf

@@ -61,8 +61,6 @@ data "aws_acm_certificate" "this" {
   domain  = "${var.certificate_name != "" ? var.certificate_name : local.cert_name }"
 }
 
-# TODO: need to separate into 2 resources to support logging, since network doesn't
-/*
 resource "aws_lb" "application" {
   count               = "${module.enabled.value && var.type == "application" ? 1 : 0}"
   name                = "${module.label.id_32}"
@@ -91,10 +89,10 @@ resource "aws_lb" "application" {
     delete  =
     update  =
   }
-  *//*
+  */
   depends_on = ["aws_s3_bucket.log_bucket"]
 }
-/*
+
 resource "aws_lb" "network" {
   count               = "${module.enabled.value && var.type == "network" ? 1 : 0}"
   name                = "${module.label.id_32}"
@@ -117,9 +115,10 @@ resource "aws_lb" "network" {
     delete  =
     update  =
   }
-  *//*
+  */
 }
-*/
+
+/*
 resource "aws_lb" "this" {
   count               = "${module.enabled.value}"
   name                = "${module.label.id_32}"
@@ -151,9 +150,10 @@ resource "aws_lb" "this" {
     delete  =
     update  =
   }
-  */
+  *//*
   depends_on = ["aws_s3_bucket.log_bucket"]
 }
+*/
 
 data "aws_iam_policy_document" "bucket_policy" {
   count  = "${
@@ -326,7 +326,8 @@ resource "aws_lb_listener" "http" {
     var.type == "application" &&
     contains(var.lb_protocols, "HTTP")
     ? length(compact(split(",", local.lb_http_ports))) : 0}"
-  load_balancer_arn = "${aws_lb.this.arn}"
+  #load_balancer_arn = "${aws_lb.this.arn}" # "${coalesce(aws_lb.application.arn, aws_lb.network.arn)}"
+  load_balancer_arn = "${coalesce(aws_lb.application.arn, aws_lb.network.arn)}"
   port              = "${element(compact(split(",",local.lb_http_ports)), count.index)}"
   protocol          = "HTTP"
   default_action {
@@ -342,7 +343,8 @@ resource "aws_lb_listener" "https" {
     var.type == "application" &&
     contains(var.lb_protocols, "HTTPS")
     ? length(compact(split(",", local.lb_https_ports))) : 0}"
-  load_balancer_arn = "${aws_lb.this.arn}"
+  #load_balancer_arn = "${aws_lb.this.arn}" # "${coalesce(aws_lb.application.arn, aws_lb.network.arn)}"
+  load_balancer_arn = "${coalesce(aws_lb.application.arn, aws_lb.network.arn)}"
   port              = "${element(compact(split(",",local.lb_https_ports)), count.index)}"
   protocol          = "HTTPS"
   certificate_arn   = "${element(concat(data.aws_acm_certificate.this.*.arn, list("")), 0)}"
@@ -359,7 +361,8 @@ resource "aws_lb_listener" "network" {
     module.enabled.value &&
     var.type == "network"
     ? length(compact(split(",", local.lb_tcp_ports))) : 0}"
-  load_balancer_arn = "${aws_lb.this.arn}"
+  #load_balancer_arn = "${aws_lb.this.arn}" # "${coalesce(aws_lb.application.arn, aws_lb.network.arn)}"
+  load_balancer_arn = "${coalesce(aws_lb.application.arn, aws_lb.network.arn)}"
   port              = "${element(compact(split(",",local.lb_tcp_ports)), count.index)}"
   protocol          = "TCP"
   default_action {

outputs.tf

@@ -3,19 +3,23 @@
 //
 output "arn" {
   description = "ARN of the LB itself. Useful for debug output, for example when attaching a WAF."
-  value       = "${element(concat(aws_lb.this.*.arn, list("")), 0)}"
+  #value       = "${element(concat(aws_lb.this.*.arn, list("")), 0)}"
+  value       = "${element(concat(aws_lb.application.*.arn, aws_lb.network.*.arn, list("")), 0)}"
 }
 output "dns_name" {
   description = "The DNS name of the LB presumably to be used with a friendlier CNAME."
-  value       = "${element(concat(aws_lb.this.*.dns_name, list("")), 0)}"
+  #value       = "${element(concat(aws_lb.this.*.dns_name, list("")), 0)}"
+  value       = "${element(concat(aws_lb.application.*.dns_name, aws_lb.network.*.dns_name, list("")), 0)}"
 }
 output "id" {
   description = "The ID of the LB we created."
-  value       = "${element(concat(aws_lb.this.*.id, list("")), 0)}"
+  #value       = "${element(concat(aws_lb.this.*.id, list("")), 0)}"
+  value       = "${element(concat(aws_lb.application.*.id, aws_lb.network.*.id, list("")), 0)}"
 }
 output "zone_id" {
   description = "The zone_id of the LB to assist with creating DNS records."
-  value       = "${element(concat(aws_lb.this.*.zone_id, list("")), 0)}"
+  #value       = "${element(concat(aws_lb.this.*.zone_id, list("")), 0)}"
+  value       = "${element(concat(aws_lb.application.*.zone_id, aws_lb.network.*.zone_id, list("")), 0)}"
 }
 # arn_suffix
 # canonical_hosted_zone_id