Skip to content

Commit 875e83a

Browse files
author
Steven Nemetz
committed
Testing ALB
1 parent 34d948c commit 875e83a

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

main.tf

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,13 @@ resource "aws_lb" "application" {
8585
security_groups = ["${var.security_groups}"]
8686
subnets = ["${var.subnets}"]
8787
tags = "${module.label.tags}"
88+
/* Doesn't seem to be able to disable properly
8889
access_logs {
89-
bucket = "${module.log_bucket.id}" # ? Cannot be empty ?
90+
bucket = "${module.log_bucket.id}" # ? Cannot be empty and must exist
9091
prefix = "${var.log_location_prefix}"
9192
enabled = "${module.enable_logging.value}"
9293
}
94+
*/
9395
/*
9496
subnet_mapping {
9597
subnet_id = "${}"

test/main.tf

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ data "aws_vpc" "vpc" {
33
Env = "one"
44
}
55
}
6+
# Look up security group
67
data "aws_subnet_ids" "public_subnet_ids" {
78
vpc_id = "${data.aws_vpc.vpc.id}"
89
tags {
@@ -16,6 +17,8 @@ data "aws_subnet_ids" "private_subnet_ids" {
1617
}
1718
}
1819

20+
# TODO: setup at least 3 LB: NLB, ALB w/o logs, ALB w/ logs
21+
# update outputs for all 3
1922
module "lb" {
2023
source = "../"
2124
name = "lb-svc"
@@ -25,9 +28,9 @@ module "lb" {
2528
#tags = "${map("Key", "Value")}"
2629
#enabled = false
2730
#health_check_path = ""
28-
security_groups = []
31+
security_groups = ["sg-a5bf1cd8"] # Need at least 1
2932
lb_protocols = ["HTTP","HTTPS"]
30-
type = "network"
33+
#type = "network"
3134
subnets = "${data.aws_subnet_ids.private_subnet_ids.ids}"
3235
vpc_id = "${data.aws_vpc.vpc.id}"
3336
ports = "3000,4000"

0 commit comments

Comments
 (0)