Skip to content

feat: enable CIRA connection in console #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
rsdmike wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: enable CIRA connection in console #133

rsdmike wants to merge 3 commits into from

Conversation

@rsdmike
Copy link
Member

@rsdmike rsdmike commented May 8, 2024

No description provided.

@codecov
Copy link

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 107 lines in your changes missing coverage. Please review.

Project coverage is 35.57%. Comparing base (15705da) to head (c2f7822).

Files Patch % Lines
internal/certificates/generate.go 0.00% 107 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   36.51%   35.57%   -0.95%     
==========================================
  Files          55       56       +1     
  Lines        4017     4124     +107     
==========================================
  Hits         1467     1467              
- Misses       2458     2565     +107     
  Partials       92       92

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsdmike rsdmike force-pushed the main branch 5 times, most recently from e0ea0e5 to 62fb1d5 Compare May 23, 2024 04:44
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2024
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 12, 2025
View reviewed changes
internal/controller/tcp/cira/tunnel.go
func (s *Server) ListenAndServe() error {
config := &tls.Config{
Certificates: []tls.Certificate{s.certificates},
InsecureSkipVerify: true,

Check failure

Code scanning / CodeQL

Disabled TLS certificate check High

InsecureSkipVerify should not be used in production code.

Copilot Autofix

AI 5 days ago

To fix the issue, remove InsecureSkipVerify: true from the TLS configuration of the server. By default, when this field is unset or false, the TLS implementation will properly verify certificate chains, hostnames, and all other security requirements for incoming connections. This change will not affect other features such as the use of custom cipher suites.

  • Edit the ListenAndServe method in internal/controller/tcp/cira/tunnel.go, specifically the tls.Config block (lines 66-70).
  • Remove line 68 setting InsecureSkipVerify: true.
  • No other imports, definitions, or functionality need to change; certificate verification will now be enforced automatically.
Suggested changeset 1
internal/controller/tcp/cira/tunnel.go

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/internal/controller/tcp/cira/tunnel.go b/internal/controller/tcp/cira/tunnel.go
--- a/internal/controller/tcp/cira/tunnel.go
+++ b/internal/controller/tcp/cira/tunnel.go
@@ -65,7 +65,6 @@
 func (s *Server) ListenAndServe() error {
 	config := &tls.Config{
 		Certificates:       []tls.Certificate{s.certificates},
-		InsecureSkipVerify: true,
 		MinVersion:         tls.VersionTLS12,
 	}
 
EOF
@@ -65,7 +65,6 @@
func (s *Server) ListenAndServe() error {
config := &tls.Config{
Certificates: []tls.Certificate{s.certificates},
InsecureSkipVerify: true,
MinVersion: tls.VersionTLS12,
}

Copilot is powered by AI and may make mistakes. Always verify output.
@rsdmike rsdmike changed the title Cira Cira test Oct 9, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 19, 2025
View reviewed changes
@rsdmike
feat: enable CIRA connection in console
66a55fd 
addresses Add Support for CIRA
Fixes #665
@rsdmike rsdmike changed the title Cira test feat: enable CIRA connection in console Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rsdmike