PHPStan 2.0

Author: dereuromark

composer.json

@@ -59,7 +59,7 @@
 		"lowest": "validate-prefer-lowest",
 		"lowest-setup": "composer update --prefer-lowest --prefer-stable --prefer-dist --no-interaction && cp composer.json composer.backup && composer require --dev dereuromark/composer-prefer-lowest && mv composer.backup composer.json",
 		"stan": "phpstan analyse",
-		"stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^1.0.0 && mv composer.backup composer.json",
+		"stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^2.0.0 && mv composer.backup composer.json",
 		"test": "phpunit",
 		"test-coverage": "phpunit --log-junit tmp/coverage/unitreport.xml --coverage-html tmp/coverage --coverage-clover tmp/coverage/coverage.xml"
 	}

src/Auth/AllowTrait.php

@@ -30,7 +30,7 @@ protected function _getAllowRule(array $params) {
 		$allowDefaults = $this->_getAllowDefaultsForCurrentParams($params);
 
 		foreach ($rules as $rule) {
-			if (isset($params['plugin']) && ($params['plugin'] !== null)) {
+			if (isset($params['plugin'])) {
 				if ($params['plugin'] !== $rule['plugin']) {
 					continue;
 				}
@@ -39,7 +39,7 @@ protected function _getAllowRule(array $params) {
 					continue;
 				}
 			}
-			if (isset($params['prefix']) && ($params['prefix'] !== null)) {
+			if (isset($params['prefix'])) {
 				if ($params['prefix'] !== $rule['prefix']) {
 					continue;
 				}

src/Controller/Component/LegacyAuthComponent.php

@@ -691,8 +691,9 @@ protected function _getUser(): bool {
 		}
 		foreach ($this->_authenticateObjects as $auth) {
 			$result = $auth->getUser($this->getController()->getRequest());
-			if (!empty($result) && is_array($result)) {
+			if ($result) {
 				$this->_authenticationProvider = $auth;
+				/** @var \Cake\Event\Event $event */
 				$event = $this->dispatchEvent('Auth.afterIdentify', [$result, $auth]);
 				if ($event->getResult() !== null) {
 					$result = $event->getResult();