ffi: StagedCommitter #1532
Draft
ffi: StagedCommitter #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking-change
nicklan
reviewed
Dec 3, 2025
|
|
||
| /// FFI callback for catalog commit operations | ||
| pub type CatalogCommitCallback = extern "C" fn( | ||
| engine: Handle<SharedExternEngine>, |
Member
There was a problem hiding this comment.
why do we need to pass the engine here?
| let path_str = staged_commit_path.as_str(); | ||
| let path_slice = unsafe { KernelStringSlice::new_unsafe(path_str) }; | ||
|
|
||
| let engine_handle = unsafe { self.engine_handle.clone_handle() }; |
Member
There was a problem hiding this comment.
i'd need to go look, but i think clone_handle() bumps the refcount, so you need to make it clear that the engine needs to free_engine after this call.
I'd prefer to no need to pass an engine at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
stacked on #1514 (only review last commit)
What changes are proposed in this pull request?
Add
StagedCommitterFFI - allow FFI engines to create aStagedCommitter(viacreate_staged_committer) and start a transaction with a committer (transaction_with_committer) to allow for catalog-managed writes to tables with existing transaction API.How was this change tested?
todo