feat: Distributed Log Replay serialization/deserialization #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2025
OussamaSaoudi
changed the title
OussamaSaoudi
force-pushed
the
stack/dlr_serde
branch
from
1e40840 to
09cf641
Compare
github-actions
bot
added
the
breaking-change
OussamaSaoudi
force-pushed
the
stack/dlr_serde
branch
6 times, most recently
from
0da2ae4 to
274c7bf
Compare
OussamaSaoudi
force-pushed
the
stack/dlr_serde
branch
from
274c7bf to
745077f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1503 +/- ##
==========================================
+ Coverage 84.55% 84.85% +0.29%
==========================================
Files 123 129 +6
Lines 33366 34826 +1460
Branches 33366 34826 +1460
==========================================
+ Hits 28213 29550 +1337
- Misses 3768 3830 +62
- Partials 1385 1446 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OussamaSaoudi
force-pushed
the
stack/dlr_serde
branch
from
87bd895 to
eec7cbd
Compare
This was referenced Dec 3, 2025
emkornfield
reviewed
Dec 5, 2025
| predicate_schema, | ||
| column_mapping_mode: self.state_info.column_mapping_mode, | ||
| }; | ||
| let internal_state_blob = serde_json::to_vec(&internal_state) |
Collaborator
There was a problem hiding this comment.
I assume we don't care too much about compatibility across binary versions here (if we do, then we might want to include a version byte, so readers can understand if the serialization format has changed).
Collaborator
Author
There was a problem hiding this comment.
Hmm good callout. I'll put that as a warning in the docs.
emkornfield
reviewed
Dec 5, 2025
| // Deserialize internal state from json | ||
| let internal_state: InternalScanState = serde_json::from_slice(&state.internal_state_blob) | ||
| .map_err(|e| Error::generic(format!("Failed to deserialize internal state: {}", e)))?; | ||
|
|
Collaborator
There was a problem hiding this comment.
for safety, should we check that there aren't any unexpected keys?
Collaborator
Author
There was a problem hiding this comment.
Good catch. Added a test for that :)
Draft
emkornfield
reviewed
Dec 6, 2025
| obj["new_field"] = serde_json::json!("my_new_value"); | ||
| let invalid_blob = obj.to_string(); | ||
|
|
||
| let internal_res: Result<InternalScanState, _> = serde_json::from_str(&invalid_blob); |
emkornfield
reviewed
Dec 6, 2025
|
|
||
| #[test] | ||
| fn deserialize_internal_state_with_extry_fields_fails() { | ||
| // Test that missing predicate_schema when predicate exists is detected |
emkornfield
approved these changes
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
This PR introduces serialization and deserialization for the ScanLogReplayProcessor.
This PR adds serialization and deserialization for LogReplayProcessor.
It also removes the StaticInsert transform since:
How was this change tested?
Round trip test is performed with the LogReplayProcessor. Invalid internal state is expected to result in an error.