-
Notifications
You must be signed in to change notification settings - Fork 127
feat: Commit Reader #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Commit Reader #1499
Conversation
07824d3 to
c32f486
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
=======================================
Coverage 84.77% 84.77%
=======================================
Files 126 127 +1
Lines 35679 35739 +60
Branches 35679 35739 +60
=======================================
+ Hits 30246 30297 +51
- Misses 3965 3966 +1
- Partials 1468 1476 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nicklan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! one small comment
| use std::sync::Arc; | ||
| use url::Url; | ||
|
|
||
| fn load_test_table( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this move into test_utils? I feel like we load test tables in a few places. If there's not already a central way to do so, maybe just make a good first issue to clean that up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I ended up moving this to test_utils in the following PR because I noticed the repetition.
f63aa3b to
703dc4e
Compare
703dc4e to
fd419c8
Compare
| let actions = engine | ||
| .json_handler() | ||
| .read_json_files(&commit_files, schema, None)? | ||
| .map(|batch| batch.map(|b| ActionsBatch::new(b, true))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| .map(|batch| batch.map(|b| ActionsBatch::new(b, true))); | |
| .map_ok(|batch| ActionsBatch::new(batch, true)); |
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
This PR adds the commit logreader, a module that will hold all the logic for processing commit files when performing log replay.
Iterator<Item = ActionBatch>.How was this change tested?
This is tested with the
app-txn-no-checkpointwhich has multiple commits and multiple add actions in each commit. We ensure that the CommitReader reads the correct set of add actions.