Skip to content

Add enableGravatar option to module #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
derekisbusy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add enableGravatar option to module #912

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c930946
Add enableGravatar option to module
derekisbusy May 8, 2017
b64e63d
Update profile.php
derekisbusy Jan 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Module.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ class Module extends BaseModule
/** @var bool Enable the 'impersonate as another user' function */
public $enableImpersonateUser = true;

/** @var bool Enable gravatar profile avatars */
public $enableGravatar = true;

/** @var int Email changing strategy. */
public $emailChangeStrategy = self::STRATEGY_DEFAULT;

Expand Down
4 changes: 2 additions & 2 deletions views/settings/profile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@
)
); ?>

<?= $form
<?= ($this->context->module->enableGravatar)? $form
Copy link
Member

@thiagotalma thiagotalma May 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use if.
Ternary not necessary here.

->field($model, 'gravatar_email')
->hint(Html::a(Yii::t('user', 'Change your avatar at Gravatar.com'), 'http://gravatar.com')) ?>
->hint(Html::a(Yii::t('user', 'Change your avatar at Gravatar.com'), 'http://gravatar.com')) : null ?>

<?= $form->field($model, 'bio')->textarea() ?>

Expand Down