Skip to content

Commit 66589bb

Browse files
author
Han Wang
committed
remove debug message and remove the test of get_return twice. do not try to get_return twice since by the first call the stdout is all read and output of the second call is not predictable.
1 parent 1a6aa7b commit 66589bb

File tree

3 files changed

+8
-11
lines changed

3 files changed

+8
-11
lines changed

dpgen/dispatcher/LazyLocalContext.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,13 @@ def check_finish(self, proc):
121121
def get_return(self, proc):
122122
ret = proc.poll()
123123
if ret is None:
124-
print('---------------- proc is None ----------------')
125124
return None, None, None
126125
else :
127126
try:
128127
o, e = proc.communicate()
129-
print('---------------- communicate finishes ----------------')
130128
stdout = SPRetObj(o)
131129
stderr = SPRetObj(e)
132130
except ValueError:
133-
print('---------------- communicate failed ----------------')
134131
stdout = None
135132
stderr = None
136133
return ret, stdout, stderr

tests/dispatcher/test_lazy_local_context.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -167,8 +167,8 @@ def test_call(self) :
167167
self.assertEqual(r, 0)
168168
self.assertEqual(o.read(), b'')
169169
self.assertEqual(e.read(), b'')
170-
r,o,e=self.job.get_return(proc)
171-
self.assertEqual(r, 0)
172-
self.assertEqual(o, None)
173-
self.assertEqual(e, None)
170+
# r,o,e=self.job.get_return(proc)
171+
# self.assertEqual(r, 0)
172+
# self.assertEqual(o, None)
173+
# self.assertEqual(e, None)
174174

tests/dispatcher/test_local_context.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -356,8 +356,8 @@ def test_call(self) :
356356
self.assertEqual(r, 0)
357357
self.assertEqual(o.read(), b'')
358358
self.assertEqual(e.read(), b'')
359-
r,o,e=self.job.get_return(proc)
360-
self.assertEqual(r, 0)
361-
self.assertEqual(o, None)
362-
self.assertEqual(e, None)
359+
# r,o,e=self.job.get_return(proc)
360+
# self.assertEqual(r, 0)
361+
# self.assertEqual(o, None)
362+
# self.assertEqual(e, None)
363363

0 commit comments

Comments
 (0)