Skip to content

Commit 5788f79

Browse files
authored
chore: fix spelling PRECISON -> PRECISION (#4508)
Luckily, this variable has never been used otherwhere. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Corrected the spelling of `RESERVED_PRECISON_DICT` to `RESERVED_PRECISION_DICT` across multiple files to ensure consistency and prevent potential runtime errors. - **Documentation** - Updated comments and documentation to reflect the corrected variable name, enhancing clarity without altering functionality. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent bd2395c commit 5788f79

File tree

17 files changed

+45
-45
lines changed

17 files changed

+45
-45
lines changed

deepmd/dpmodel/common.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
}
4444
assert VALID_PRECISION.issubset(PRECISION_DICT.keys())
4545

46-
RESERVED_PRECISON_DICT = {
46+
RESERVED_PRECISION_DICT = {
4747
np.float16: "float16",
4848
np.float32: "float32",
4949
np.float64: "float64",
@@ -52,7 +52,7 @@
5252
ml_dtypes.bfloat16: "bfloat16",
5353
np.bool_: "bool",
5454
}
55-
assert set(RESERVED_PRECISON_DICT.keys()) == set(PRECISION_DICT.values())
55+
assert set(RESERVED_PRECISION_DICT.keys()) == set(PRECISION_DICT.values())
5656
DEFAULT_PRECISION = "float64"
5757

5858

@@ -74,9 +74,9 @@ def get_xp_precision(
7474
elif precision == "bool":
7575
return bool
7676
elif precision == "default":
77-
return get_xp_precision(xp, RESERVED_PRECISON_DICT[PRECISION_DICT[precision]])
77+
return get_xp_precision(xp, RESERVED_PRECISION_DICT[PRECISION_DICT[precision]])
7878
elif precision == "global":
79-
return get_xp_precision(xp, RESERVED_PRECISON_DICT[GLOBAL_NP_FLOAT_PRECISION])
79+
return get_xp_precision(xp, RESERVED_PRECISION_DICT[GLOBAL_NP_FLOAT_PRECISION])
8080
elif precision == "bfloat16":
8181
return ml_dtypes.bfloat16
8282
else:
@@ -225,6 +225,6 @@ def safe_cast_array(
225225
"GLOBAL_ENER_FLOAT_PRECISION",
226226
"GLOBAL_NP_FLOAT_PRECISION",
227227
"PRECISION_DICT",
228-
"RESERVED_PRECISON_DICT",
228+
"RESERVED_PRECISION_DICT",
229229
"NativeOP",
230230
]

deepmd/dpmodel/model/make_model.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
GLOBAL_ENER_FLOAT_PRECISION,
1515
GLOBAL_NP_FLOAT_PRECISION,
1616
PRECISION_DICT,
17-
RESERVED_PRECISON_DICT,
17+
RESERVED_PRECISION_DICT,
1818
NativeOP,
1919
)
2020
from deepmd.dpmodel.model.base_model import (
@@ -169,7 +169,7 @@ def __init__(
169169
self.atomic_model: T_AtomicModel = T_AtomicModel(*args, **kwargs)
170170
self.precision_dict = PRECISION_DICT
171171
# not supported by flax
172-
# self.reverse_precision_dict = RESERVED_PRECISON_DICT
172+
# self.reverse_precision_dict = RESERVED_PRECISION_DICT
173173
self.global_np_float_precision = GLOBAL_NP_FLOAT_PRECISION
174174
self.global_ener_float_precision = GLOBAL_ENER_FLOAT_PRECISION
175175

@@ -373,7 +373,7 @@ def input_type_cast(
373373
str,
374374
]:
375375
"""Cast the input data to global float type."""
376-
input_prec = RESERVED_PRECISON_DICT[self.precision_dict[coord.dtype.name]]
376+
input_prec = RESERVED_PRECISION_DICT[self.precision_dict[coord.dtype.name]]
377377
###
378378
### type checking would not pass jit, convert to coord prec anyway
379379
###
@@ -382,7 +382,7 @@ def input_type_cast(
382382
for vv in [box, fparam, aparam]
383383
]
384384
box, fparam, aparam = _lst
385-
if input_prec == RESERVED_PRECISON_DICT[self.global_np_float_precision]:
385+
if input_prec == RESERVED_PRECISION_DICT[self.global_np_float_precision]:
386386
return coord, box, fparam, aparam, input_prec
387387
else:
388388
pp = self.global_np_float_precision
@@ -401,7 +401,7 @@ def output_type_cast(
401401
) -> dict[str, np.ndarray]:
402402
"""Convert the model output to the input prec."""
403403
do_cast = (
404-
input_prec != RESERVED_PRECISON_DICT[self.global_np_float_precision]
404+
input_prec != RESERVED_PRECISION_DICT[self.global_np_float_precision]
405405
)
406406
pp = self.precision_dict[input_prec]
407407
odef = self.model_output_def()

deepmd/pd/infer/deep_eval.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
from deepmd.pd.utils.env import (
3636
DEVICE,
3737
GLOBAL_PD_FLOAT_PRECISION,
38-
RESERVED_PRECISON_DICT,
38+
RESERVED_PRECISION_DICT,
3939
enable_prim,
4040
)
4141
from deepmd.pd.utils.utils import (
@@ -355,7 +355,7 @@ def _eval_model(
355355
request_defs: list[OutputVariableDef],
356356
):
357357
model = self.dp.to(DEVICE)
358-
prec = NP_PRECISION_DICT[RESERVED_PRECISON_DICT[GLOBAL_PD_FLOAT_PRECISION]]
358+
prec = NP_PRECISION_DICT[RESERVED_PRECISION_DICT[GLOBAL_PD_FLOAT_PRECISION]]
359359

360360
nframes = coords.shape[0]
361361
if len(atom_types.shape) == 1:
@@ -370,7 +370,7 @@ def _eval_model(
370370
place=DEVICE,
371371
)
372372
type_input = paddle.to_tensor(
373-
atom_types.astype(NP_PRECISION_DICT[RESERVED_PRECISON_DICT[paddle.int64]]),
373+
atom_types.astype(NP_PRECISION_DICT[RESERVED_PRECISION_DICT[paddle.int64]]),
374374
dtype=paddle.int64,
375375
place=DEVICE,
376376
)

deepmd/pd/model/descriptor/dpa1.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
)
2424
from deepmd.pd.utils.env import (
2525
PRECISION_DICT,
26-
RESERVED_PRECISON_DICT,
26+
RESERVED_PRECISION_DICT,
2727
)
2828
from deepmd.pd.utils.update_sel import (
2929
UpdateSel,
@@ -503,7 +503,7 @@ def serialize(self) -> dict:
503503
"use_tebd_bias": self.use_tebd_bias,
504504
"type_map": self.type_map,
505505
# make deterministic
506-
"precision": RESERVED_PRECISON_DICT[obj.prec],
506+
"precision": RESERVED_PRECISION_DICT[obj.prec],
507507
"embeddings": obj.filter_layers.serialize(),
508508
"attention_layers": obj.dpa1_attention.serialize(),
509509
"env_mat": DPEnvMat(obj.rcut, obj.rcut_smth).serialize(),

deepmd/pd/model/descriptor/se_a.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
)
2424
from deepmd.pd.utils.env import (
2525
PRECISION_DICT,
26-
RESERVED_PRECISON_DICT,
26+
RESERVED_PRECISION_DICT,
2727
)
2828
from deepmd.pd.utils.env_mat_stat import (
2929
EnvMatStatSe,
@@ -334,7 +334,7 @@ def serialize(self) -> dict:
334334
"set_davg_zero": obj.set_davg_zero,
335335
"activation_function": obj.activation_function,
336336
# make deterministic
337-
"precision": RESERVED_PRECISON_DICT[obj.prec],
337+
"precision": RESERVED_PRECISION_DICT[obj.prec],
338338
"embeddings": obj.filter_layers.serialize(),
339339
"env_mat": DPEnvMat(obj.rcut, obj.rcut_smth).serialize(),
340340
"exclude_types": obj.exclude_types,

deepmd/pd/model/descriptor/se_t_tebd.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
)
3131
from deepmd.pd.utils.env import (
3232
PRECISION_DICT,
33-
RESERVED_PRECISON_DICT,
33+
RESERVED_PRECISION_DICT,
3434
)
3535
from deepmd.pd.utils.env_mat_stat import (
3636
EnvMatStatSe,
@@ -358,7 +358,7 @@ def serialize(self) -> dict:
358358
"use_econf_tebd": self.use_econf_tebd,
359359
"type_map": self.type_map,
360360
# make deterministic
361-
"precision": RESERVED_PRECISON_DICT[obj.prec],
361+
"precision": RESERVED_PRECISION_DICT[obj.prec],
362362
"embeddings": obj.filter_layers.serialize(),
363363
"env_mat": DPEnvMat(obj.rcut, obj.rcut_smth).serialize(),
364364
"type_embedding": self.type_embedding.embedding.serialize(),

deepmd/pd/model/model/make_model.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
GLOBAL_PD_ENER_FLOAT_PRECISION,
2929
GLOBAL_PD_FLOAT_PRECISION,
3030
PRECISION_DICT,
31-
RESERVED_PRECISON_DICT,
31+
RESERVED_PRECISION_DICT,
3232
)
3333
from deepmd.pd.utils.nlist import (
3434
extend_input_and_build_neighbor_list,
@@ -76,7 +76,7 @@ def __init__(
7676
else:
7777
self.atomic_model: T_AtomicModel = T_AtomicModel(*args, **kwargs)
7878
self.precision_dict = PRECISION_DICT
79-
self.reverse_precision_dict = RESERVED_PRECISON_DICT
79+
self.reverse_precision_dict = RESERVED_PRECISION_DICT
8080
self.global_pd_float_precision = GLOBAL_PD_FLOAT_PRECISION
8181
self.global_pd_ener_float_precision = GLOBAL_PD_ENER_FLOAT_PRECISION
8282

deepmd/pd/utils/env.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
PRECISION_DICT["default"] = GLOBAL_PD_FLOAT_PRECISION
5656
assert VALID_PRECISION.issubset(PRECISION_DICT.keys())
5757
# cannot automatically generated
58-
RESERVED_PRECISON_DICT = {
58+
RESERVED_PRECISION_DICT = {
5959
paddle.float16: "float16",
6060
paddle.float32: "float32",
6161
paddle.float64: "float64",
@@ -64,7 +64,7 @@
6464
paddle.bfloat16: "bfloat16",
6565
paddle.bool: "bool",
6666
}
67-
assert set(PRECISION_DICT.values()) == set(RESERVED_PRECISON_DICT.keys())
67+
assert set(PRECISION_DICT.values()) == set(RESERVED_PRECISION_DICT.keys())
6868
DEFAULT_PRECISION = "float64"
6969

7070
# throw warnings if threads not set
@@ -163,7 +163,7 @@ def enable_prim(enable: bool = True):
163163
"LOCAL_RANK",
164164
"NUM_WORKERS",
165165
"PRECISION_DICT",
166-
"RESERVED_PRECISON_DICT",
166+
"RESERVED_PRECISION_DICT",
167167
"SAMPLER_RECORD",
168168
"enable_prim",
169169
]

deepmd/pt/infer/deep_eval.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
from deepmd.pt.utils.env import (
5959
DEVICE,
6060
GLOBAL_PT_FLOAT_PRECISION,
61-
RESERVED_PRECISON_DICT,
61+
RESERVED_PRECISION_DICT,
6262
)
6363
from deepmd.pt.utils.utils import (
6464
to_numpy_array,
@@ -406,7 +406,7 @@ def _eval_model(
406406
request_defs: list[OutputVariableDef],
407407
):
408408
model = self.dp.to(DEVICE)
409-
prec = NP_PRECISION_DICT[RESERVED_PRECISON_DICT[GLOBAL_PT_FLOAT_PRECISION]]
409+
prec = NP_PRECISION_DICT[RESERVED_PRECISION_DICT[GLOBAL_PT_FLOAT_PRECISION]]
410410

411411
nframes = coords.shape[0]
412412
if len(atom_types.shape) == 1:
@@ -421,7 +421,7 @@ def _eval_model(
421421
device=DEVICE,
422422
)
423423
type_input = torch.tensor(
424-
atom_types.astype(NP_PRECISION_DICT[RESERVED_PRECISON_DICT[torch.long]]),
424+
atom_types.astype(NP_PRECISION_DICT[RESERVED_PRECISION_DICT[torch.long]]),
425425
dtype=torch.long,
426426
device=DEVICE,
427427
)
@@ -553,7 +553,7 @@ def _eval_model_spin(
553553
np.abs(shape),
554554
np.nan,
555555
dtype=NP_PRECISION_DICT[
556-
RESERVED_PRECISON_DICT[GLOBAL_PT_FLOAT_PRECISION]
556+
RESERVED_PRECISION_DICT[GLOBAL_PT_FLOAT_PRECISION]
557557
],
558558
)
559559
) # this is kinda hacky

deepmd/pt/model/descriptor/dpa1.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
)
2424
from deepmd.pt.utils.env import (
2525
PRECISION_DICT,
26-
RESERVED_PRECISON_DICT,
26+
RESERVED_PRECISION_DICT,
2727
)
2828
from deepmd.pt.utils.tabulate import (
2929
DPTabulate,
@@ -505,7 +505,7 @@ def serialize(self) -> dict:
505505
"use_tebd_bias": self.use_tebd_bias,
506506
"type_map": self.type_map,
507507
# make deterministic
508-
"precision": RESERVED_PRECISON_DICT[obj.prec],
508+
"precision": RESERVED_PRECISION_DICT[obj.prec],
509509
"embeddings": obj.filter_layers.serialize(),
510510
"attention_layers": obj.dpa1_attention.serialize(),
511511
"env_mat": DPEnvMat(obj.rcut, obj.rcut_smth).serialize(),

0 commit comments

Comments
 (0)