Commit 46411c1
Profile bug fix when both enable_profiler and profiling are set to true. (#4855)
When enable_profiler has been set to true, it will save the profiling
results into json format in the tensorboard_log_dir. Currently, when
both enable_profiler and profiling are set to true, it will throw an
error `RuntimeError: Trace is already saved`. As a result, just ignore
the profiling option when enable_profiler is true.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Bug Fixes**
* Refined profiling trace export logic to prevent duplicate or
unintended trace exports when the new profiler is enabled. Profiling
traces are now only exported if profiling is enabled and the new
profiler is not active.
* **Documentation**
* Updated profiling documentation to clarify that when the new profiler
is enabled, profiling results are saved to TensorBoard logs instead of a
Chrome JSON file.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Signed-off-by: LI TIANCHENG <137472077+OutisLi@users.noreply.github.com>
Co-authored-by: Jinzhe Zeng <njzjz@qq.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>1 parent 91ebe34 commit 46411c1
2 files changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1147 | 1147 | | |
1148 | 1148 | | |
1149 | 1149 | | |
1150 | | - | |
| 1150 | + | |
1151 | 1151 | | |
1152 | 1152 | | |
1153 | 1153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3140 | 3140 | | |
3141 | 3141 | | |
3142 | 3142 | | |
3143 | | - | |
| 3143 | + | |
3144 | 3144 | | |
3145 | 3145 | | |
3146 | 3146 | | |
| |||
0 commit comments