Skip to content

Commit 71c5bd0

Browse files
authored
Merge pull request #354 from deepmodeling/fix-prescript-op
fix: prescript op
2 parents 1721e7d + 518b576 commit 71c5bd0

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

.github/workflows/run.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
3535
- name: Manual Approval
3636
uses: trstringer/manual-approval@v1
37+
if: github.event_name == 'push'
3738
with:
3839
secret: ${{ github.token }}
3940
approvers: ${{ vars.APPROVERS }}

lambench/models/ase_models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,9 +284,9 @@ def run_ase_dptest(
284284
dpdata.LabeledSystem.register_data_type(datatype)
285285

286286
calc = model.calc
287-
if dispersion_correction:
287+
if dispersion_correction is not None:
288288
calc = SumCalculator(
289-
[calc, DFTD3(method="PBE", dispersion_correction=dispersion_correction)]
289+
[calc, DFTD3(method="PBE", damping=dispersion_correction)]
290290
)
291291

292292
energy_err = []

lambench/workflow/dflow.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
from dflow.python import OP, Artifact, PythonOPTemplate
1515

1616
import dpdata
17-
import dftd3
18-
import pycparser
1917

2018
import lambench
2119
from lambench.models.basemodel import BaseLargeAtomModel
@@ -63,9 +61,9 @@ def submit_tasks_dflow(
6361
image=model.virtualenv,
6462
envs={k: v for k, v in os.environ.items() if k.startswith("MYSQL")},
6563
python_packages=[
66-
Path(package.__path__[0])
67-
for package in [lambench, dpdata, dftd3, pycparser]
64+
Path(package.__path__[0]) for package in [lambench, dpdata]
6865
],
66+
pre_script="import os\nos.system('pip install dftd3')\n",
6967
),
7068
parameters={
7169
"task": task,

0 commit comments

Comments
 (0)