hotfix: wearables hiding themselves (#5508)

fix: wearables hiding themselves

Author: Patricio Guerra

unity-renderer/Assets/Scripts/MainScripts/DCL/Models/AvatarAssets/Tests/WearableItemShould.cs

@@ -8,6 +8,31 @@ public class WearableItemShould
     {
         private const string BODY_SHAPE = "male";
 
+        [Test]
+        public void WearableCantHideItself()
+        {
+            var wearable = new WearableItem
+            {
+                data = new WearableItem.Data
+                {
+                    category = WearableLiterals.Categories.UPPER_BODY,
+                    representations = new[]
+                    {
+                        new WearableItem.Representation
+                        {
+                            bodyShapes = new[] { BODY_SHAPE },
+                            overrideHides = new [] {WearableLiterals.Categories.UPPER_BODY }
+                        }
+                    },
+                    hides = new [] {WearableLiterals.Categories.UPPER_BODY }
+                }
+            };
+
+            string[] hides = wearable.GetHidesList(BODY_SHAPE);
+
+            Assert.IsTrue(!hides.Contains(WearableLiterals.Categories.UPPER_BODY), "Wearable does not contain its own category");
+        }
+
         [Test]
         public void GetHideCategoriesWhenIsSkin()
         {

unity-renderer/Assets/Scripts/MainScripts/DCL/Models/AvatarAssets/WearableItem.cs

@@ -247,6 +247,9 @@ public string[] GetHidesList(string bodyShapeType)
         if (replaces != null)
             hides.UnionWith(replaces);
 
+        // Safeguard so no wearable can hide itself
+        hides.Remove(data.category);
+
         return hides.ToArray();
     }