Fix: profile links regex (#6137)

Author: AlejandroAlvarezMelucciDCL

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/MyAccountHUD/LinkValidator.cs

@@ -0,0 +1,19 @@
+using System.Text.RegularExpressions;
+
+namespace DCL.MyAccount
+{
+    /// <summary>
+    /// A helper class to validate urls. These must start either with http or https.
+    /// </summary>
+    public static class LinkValidator
+    {
+        private static readonly Regex httpRegex = new (@"^(?:https?):\/\/[^\s\/$.?#].[^\s]*$");
+
+        /// <summary>
+        /// Validates a given url checking if it starts with http or https.
+        /// </summary>
+        /// <param name="url">The url to validate.</param>
+        /// <returns>Whether the url is valid or not.</returns>
+        public static bool IsValid(string url) => httpRegex.IsMatch(url);
+    }
+}

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/MyAccountHUD/LinkValidator.cs.meta

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Generic;
-using System.Text.RegularExpressions;
 using TMPro;
 using UnityEngine;
 using UnityEngine.Networking;
@@ -17,7 +16,6 @@ public class MyProfileLinkListComponentView : MonoBehaviour
         [SerializeField] private RectTransform linksContainer;
 
         private readonly List<MyProfileLinkComponentView> links = new ();
-        private readonly Regex httpRegex = new ("^((https?:)?\\/\\/)?([\\da-z.-]+)\\.([a-z.]{2,6})([\\/\\w .%@()\\-]*)*\\/?$");
 
         private bool isAddEnabled = true;
 
@@ -77,7 +75,7 @@ public void EnableOrDisableAddNewLinkOption(bool enabled)
         private void EnableOrDisableAddButton()
         {
             addButton.interactable = newLinkTitle.text.Length > 0 && newLinkUrl.text.Length > 0
-                                                                  && httpRegex.IsMatch(newLinkUrl.text)
+                                                                  && LinkValidator.IsValid(newLinkUrl.text)
                                                                   && isAddEnabled;
         }
     }

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/MyAccountHUD/MyProfileLinkListComponentView.cs

@@ -0,0 +1,20 @@
+using NUnit.Framework;
+using UnityEngine;
+using UnityEngine.TestTools;
+
+namespace DCL.MyAccount
+{
+    public class LinkValidatorShould
+    {
+        [UnityPlatform(RuntimePlatform.WindowsEditor, RuntimePlatform.OSXEditor, RuntimePlatform.LinuxEditor)]
+        [TestCase("https://alink.com?aVar=aValue&anotherVar=anotherValue", true)]
+        [TestCase("https://alink.com?someVar=some%20value", true)]
+        [TestCase("https://alink.com", true)]
+        [TestCase("http://alink.com'", true)]
+        [TestCase("javascript:window%5b%22ale%22%2b%22rt%22%5d(document.domain)//.com", false)]
+        public void IsValid(string url, bool expectedResult)
+        {
+            Assert.True(LinkValidator.IsValid(url) == expectedResult);
+        }
+    }
+}

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/MyAccountHUD/Tests/EditModeTests.meta

@@ -0,0 +1,3 @@
+{
+    "reference": "GUID:c4ac1fe5aa954bb4facfed6d10c73d3d"
+}

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/MyAccountHUD/Tests/EditModeTests/LinkValidatorShould.cs

@@ -55,7 +55,8 @@
         "GUID:6426fc92c49cbb342916620a1009be8d",
         "GUID:fd6a19eb8dfe417a84a27e537222d98d",
         "GUID:c34e38f41494f834abff029ddf82af43",
-        "GUID:43315b150e1df4592868fc0fe58b3429"
+        "GUID:43315b150e1df4592868fc0fe58b3429",
+        "GUID:0f15c7a7fa0e4b94aaceddb51ad829ac"
     ],
     "includePlatforms": [
         "Editor"