Release 2023 08 14 (#5582)

* bump scene-runtime. Fix sdk sourcemaps (#5554)

* feat: Integrate single sign on (#5548)

* feat: Integrate single sign on

* fix: Update client

* fix: Update client

* fix: Update single sign on client

* fix: Update client

* feat: Update sso client

* feat: Update sso client

* feat: Sso url by query param

* fix: Update package

* fix: add `sourceType` property to `getActiveVideoStreams` response (#5571)

* fix: Update sso client (#5570)

* fix: removed link escaping when sending to kernel (#5568)

* Reduce the transaction amount again (#5578)

* Feat: camera reel polishing (#5544)

## What does this PR change?
This PR polishes CameraReel and Screencapture features (for the InWorld Camera initiative).

It includes major refactoring of both components. 

On screencapture side
- Cinemachine was introduced in Camera movement logic 
- Screenshot capturing HDR fixed, but with heavy texture upsacle, crop and resize operations
- Name tags added also to Avatar

On Camera Reel (Gallery) there were a lot of refactoring and polishing, adding transition and missing logic
- Metrics were also added

## How to test the changes?
You can follow this page to check all requirements https://www.notion.so/decentraland/In-World-Camera-736683ff6b2d4532ad71c873f7de522d

- ScreenCapture
1. Launch the explorer
2. Open screencapture camera by button below minimap or via keyboard C
3. Position camera by moving it (see shortcuts in the bottom-left). Check that you cannot pass through colliders and that you cannot go super far away (it should be bounded by sphere around of the player ~16 meters)
4. Check that all buttons in this view are functional - you can take close it, show/hide shortcut panel, take screenshot (animation should be there with SFX), and open CameraRell 

- CameraReel Gallery
1. Open Gallery via shortcut K or in the ExploreMenu
2. Check sorting of the images and that new pictures added as first (at the top-left).
3. Check that you can delete/copy link/share twitter from the 3 dots on each picture
4. Check that downloaded resolution of pictures is 1920x1080 no matter what resolutions was your screen

- CameraReel Screenshot Viewer
1. Open one screenshot from the Gallery by clicking on it
2. Verify that you can see persons and wearables info on the ride panel
3. Verify that you can jump to a place by clicking on the Scene button in the right panel
4. Veriy that you can open Marketplace by clicking on the Wearables from the list

* chore: bumping schema versions and fixing test (#5581)

Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>

* Hotfix: Swap C and H as a new shortcut for control panel (#5586)

Changed UI representation from C to H for both tutorial and Controls screen

* Hotfix: disable CameraReel for guests users (#5585)

disable CameraReel for guests users

* Hotfix: first person vie screenshot camera stuck and jump/run animation freeze (#5588)

* enter 3rd person view on enabling screenshot camera

* fix avatar freeze in animation

* set flag for the transition

---------

Co-authored-by: Gon Pombo <gonzalo@decentraland.org>
Co-authored-by: Fernando Zavalia <24811313+fzavalia@users.noreply.github.com>
Co-authored-by: pbosio <pato@decentraland.org>
Co-authored-by: Ashley Canning <ashley.canning@decentraland.org>
Co-authored-by: Vitaly Popuzin <35366872+popuz@users.noreply.github.com>
Co-authored-by: Miguel Oliva <moliva@users.noreply.github.com>
Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com>
Co-authored-by: D-Fabio <10808443+0xD-Fabio@users.noreply.github.com>

Author: 9 people

browser-interface/package-lock.json

@@ -62,10 +62,11 @@
     "@dcl/hashing": "^1.1.3",
     "@dcl/kernel-interface": "^2.0.0-20230512115658.commit-b582e05",
     "@dcl/legacy-ecs": "^6.11.11",
-    "@dcl/protocol": "^1.0.0-5752058730.commit-921fc5d",
+    "@dcl/protocol": "^1.0.0-5812097343.commit-8025576",
     "@dcl/rpc": "^1.1.1",
-    "@dcl/scene-runtime": "7.0.6-20230803143954.commit-ad6c961",
-    "@dcl/schemas": "^7.4.1",
+    "@dcl/scene-runtime": "7.0.6-20230809174058.commit-2408927",
+    "@dcl/schemas": "^9.1.1",
+    "@dcl/single-sign-on-client": "^0.0.12",
     "@dcl/urn-resolver": "^2.2.0",
     "@types/mocha": "^10.0.1",
     "@types/redux-logger": "^3.0.9",

browser-interface/package.json

@@ -75,6 +75,8 @@ export const QS_MAX_VISIBLE_PEERS =
 export const BUILDER_SERVER_URL =
   ensureSingleString(qs.get('BUILDER_SERVER_URL')) ?? 'https://builder-api.decentraland.org/v1'
 
+export const SSO_URL = ensureSingleString(qs.get('SSO_URL')) ?? 'https://id.decentraland.org'
+
 /**
  * Get the root URL and ensure not to end with slash
  * @returns Root URL with pathname where the index.html is served.

browser-interface/packages/config/index.ts

@@ -1,6 +1,7 @@
-import { ETHEREUM_NETWORK, HAS_INITIAL_POSITION_MARK } from 'config/index'
+import { ETHEREUM_NETWORK, HAS_INITIAL_POSITION_MARK, SSO_URL } from 'config/index'
 import { WebSocketProvider } from 'eth-connect'
 import { IDecentralandKernel, IEthereumProvider, KernelOptions, KernelResult, LoginState } from '@dcl/kernel-interface'
+import * as SingleSignOn from '@dcl/single-sign-on-client'
 import { getFromPersistentStorage, setPersistentStorage } from 'lib/browser/persistentStorage'
 import { gridToWorld } from 'lib/decentraland/parcels/gridToWorld'
 import { parseParcelPosition } from 'lib/decentraland/parcels/parseParcelPosition'
@@ -31,6 +32,8 @@ import { isWebGLCompatible } from './validations'
 declare const globalThis: { DecentralandKernel: IDecentralandKernel }
 globalThis.DecentralandKernel = {
   async initKernel(options: KernelOptions): Promise<KernelResult> {
+    SingleSignOn.init(SSO_URL)
+
     await setupBaseUrl(options)
 
     ensureValidWebGLCanvasContainer(options)

browser-interface/packages/entryPoints/index.ts

@@ -1,39 +1,44 @@
 import type { RpcServerPort } from '@dcl/rpc'
 import * as codegen from '@dcl/rpc/dist/codegen'
 import type { PortContext } from './context'
-import { VideoTracksActiveStreamsRequest, VideoTracksActiveStreamsData, CommsApiServiceDefinition } from 'shared/protocol/decentraland/kernel/apis/comms_api.gen'
+import { VideoTracksActiveStreamsRequest, VideoTracksActiveStreamsData, CommsApiServiceDefinition, VideoTrackSourceType } from 'shared/protocol/decentraland/kernel/apis/comms_api.gen'
 import { isWorldLoaderActive } from 'shared/realm/selectors'
 import { store } from 'shared/store/isolatedStore'
 import { getLivekitActiveVideoStreams } from 'shared/comms/selectors'
 import { ensureRealmAdapter } from 'shared/realm/ensureRealmAdapter'
 import { ActiveVideoStreams } from 'shared/comms/adapters/types'
+import { Track } from 'livekit-client'
 
 export function registerCommsApiServiceServerImplementation(port: RpcServerPort<PortContext>) {
     codegen.registerService(port, CommsApiServiceDefinition, async () => ({
         async getActiveVideoStreams(req: VideoTracksActiveStreamsRequest, ctx: PortContext) {
 
             const realmAdapter = await ensureRealmAdapter()
             const isWorld = isWorldLoaderActive(realmAdapter)
-            if (!isWorld){
+            if (!isWorld) {
                 ctx.logger.error('API only available for Worlds')
                 return { streams: [] }
             }
 
-            // TODO: scene permissions?
             const activeVideoStreams: Map<string, ActiveVideoStreams> | undefined = getLivekitActiveVideoStreams(store.getState())
 
             if (!activeVideoStreams)
                 return { streams: [] }
 
             let streams: VideoTracksActiveStreamsData[] = []
 
-            for (let [sid, videoStreamData] of activeVideoStreams) {
+            for (const [sid, videoStreamData] of activeVideoStreams) {
                 if (videoStreamData.videoTracks.size > 0) {
-                    for (let [videoSid, _] of videoStreamData.videoTracks) {
-                        streams.push({
-                            identity: videoStreamData.identity,
-                            trackSid: `livekit-video://${sid}/${videoSid}`
-                        })
+                    for (const [videoSid, trackData] of videoStreamData.videoTracks) {
+                        if (!!trackData.source) {
+                            streams.push({
+                                identity: videoStreamData.identity,
+                                trackSid: `livekit-video://${sid}/${videoSid}`,
+                                sourceType: trackData.source === Track.Source.Camera ? VideoTrackSourceType.VTST_CAMERA
+                                    : trackData.source === Track.Source.ScreenShare ? VideoTrackSourceType.VTST_SCREEN_SHARE
+                                        : VideoTrackSourceType.VTST_UNKNOWN
+                            })
+                        }
                     }
                 }
             }

browser-interface/packages/shared/apis/host/CommsAPI.ts

@@ -7,7 +7,8 @@ import {
   Participant,
   RemoteParticipant,
   Room,
-  RoomEvent
+  RoomEvent,
+  Track
 } from 'livekit-client'
 import mitt from 'mitt'
 import { trackEvent } from 'shared/analytics/trackEvent'
@@ -149,10 +150,10 @@ export class LivekitAdapter implements MinimumCommunicationsAdapter {
 
     for (const [sid, participant] of participants) {
       if (participant.videoTracks.size > 0) {
-        const participantTracks = new Map<string, MediaStream>()
+        const participantTracks = new Map<string, Track>()
         for (const [videoSid, track] of participant.videoTracks) {
           if (track.videoTrack?.mediaStream) {
-            participantTracks.set(videoSid, track.videoTrack.mediaStream)
+            participantTracks.set(videoSid, track.videoTrack)
           }
         }
         result.set(sid, { identity: participant.identity, videoTracks: participantTracks })

browser-interface/packages/shared/comms/adapters/LivekitAdapter.ts

@@ -1,5 +1,6 @@
 import { Emitter } from 'mitt'
 import { VoiceHandler } from 'shared/voiceChat/VoiceHandler'
+import { Track } from 'livekit-client'
 
 export interface MinimumCommunicationsAdapter {
   /**
@@ -63,5 +64,5 @@ export type AdapterMessageEvent = {
 
 export type ActiveVideoStreams = {
   identity: string
-  videoTracks: Map<string, MediaStream>
+  videoTracks: Map<string, Track>
 }

browser-interface/packages/shared/comms/adapters/types.ts

@@ -1,3 +1,4 @@
+import * as SingleSignOn from '@dcl/single-sign-on-client'
 import {
   getFromPersistentStorage,
   getKeysFromPersistentStorage,
@@ -23,6 +24,8 @@ export const storeSession: (session: StoredSession) => Promise<void> = async (se
 export const deleteSession = async (userId?: string) => {
   if (userId) {
     await removeFromPersistentStorage(sessionKey(userId))
+
+    await SingleSignOn.clearIdentity(userId)
   }
 }
 
@@ -32,18 +35,35 @@ export const deleteSession = async (userId?: string) => {
 export const retrieveLastSessionByAddress: (address: string) => Promise<StoredSession | null> = async (
   address: string
 ) => {
-  const sessions = (await retrieveAllCurrentSessions()).filter(withAddress(address))
-
-  return sessions.length > 0 ? sessions[0] : null
+  return getSessionWithSSOIdentity((await retrieveAllCurrentSessions()).filter(withAddress(address)))
 }
 
 /**
  * Retrieve the last session stored that is a guest session
  */
 export const retrieveLastGuestSession: () => Promise<StoredSession | null> = async () => {
-  const sessions = (await retrieveAllCurrentSessions()).filter(isGuest).sort(byExpiration)
+  return getSessionWithSSOIdentity((await retrieveAllCurrentSessions()).filter(isGuest).sort(byExpiration))
+}
+
+/**
+ * From a list of sessions return the first one with the SSO identity
+ */
+async function getSessionWithSSOIdentity(sessions: StoredSession[]) {
+  if (!sessions.length) {
+    return null
+  }
+
+  const session = sessions[0]
+
+  const ssoIdentity = await SingleSignOn.getIdentity(session.identity.address)
+
+  if (!ssoIdentity) {
+    return null
+  }
+
+  session.identity = { ...session.identity, ...ssoIdentity }
 
-  return sessions.length > 0 ? sessions[0] : null
+  return session
 }
 
 /**

browser-interface/packages/shared/session/index.ts

@@ -1,5 +1,6 @@
-import { Authenticator } from '@dcl/crypto'
+import { AuthIdentity, Authenticator } from '@dcl/crypto'
 import { createUnsafeIdentity } from '@dcl/crypto/dist/crypto'
+import * as SingleSignOn from '@dcl/single-sign-on-client'
 import {
   DEBUG_KERNEL_LOG,
   ETHEREUM_NETWORK,
@@ -316,7 +317,17 @@ async function createAuthIdentity(requestManager: RequestManager, isGuest: boole
 
   const { address, signer, hasConnectedWeb3, ephemeralLifespanMinutes } = await getSigner(requestManager, isGuest)
 
-  const auth = await Authenticator.initializeAuthChain(address, ephemeral, ephemeralLifespanMinutes, signer)
+  let auth: AuthIdentity
+
+  const ssoIdentity = await SingleSignOn.getIdentity(address)
+
+  if (!ssoIdentity) {
+    auth = await Authenticator.initializeAuthChain(address, ephemeral, ephemeralLifespanMinutes, signer)
+
+    await SingleSignOn.storeIdentity(address, auth)
+  } else {
+    auth = ssoIdentity
+  }
 
   return { ...auth, rawAddress: address, address: address.toLowerCase(), hasConnectedWeb3 }
 }

browser-interface/packages/shared/session/sagas.ts

@@ -149,7 +149,7 @@ async function initializeWebRenderer(options: RendererOptions): Promise<Decentra
         const videoSid = split[split.length - 1]
         const participantSid = split[split.length - 2]
         const activeVideoStreams: Map<string, ActiveVideoStreams> | undefined = getLivekitActiveVideoStreams(store.getState())
-        return activeVideoStreams?.get(participantSid)?.videoTracks.get(videoSid)
+        return activeVideoStreams?.get(participantSid)?.videoTracks.get(videoSid)?.mediaStream
       }
     }
   }