fix: sdk7 avatar shape transform-tween reaction (#6019)

* Added needed OnTransformChanged event call on sdk7 Transform handler and Tween systems, so that the AvatarShape can reacto to the transform modifications and interpolate accordingly.
* Removed in modifier in some OnTransformChanged() methods

Author: pravusjif

unity-renderer/Assets/DCLPlugins/ECS7/ECSComponents/AvatarShape/AvatarShape.cs

@@ -381,13 +381,12 @@ public void EnablePassport()
             onPointerDown.SetPassportEnabled(true);
         }
 
-        private void OnEntityTransformChanged(object newModel)
+        private void OnEntityTransformChanged(Vector3 newPosition, Quaternion newRotation)
         {
-            DCLTransform.Model newTransformModel = (DCLTransform.Model)newModel;
-            OnEntityTransformChanged(newTransformModel.position, newTransformModel.rotation, !initializedPosition);
+            OnEntityTransformChanged(newPosition, newRotation, !initializedPosition);
         }
 
-        private void OnEntityTransformChanged(in Vector3 position, in Quaternion rotation, bool inmediate)
+        private void OnEntityTransformChanged(Vector3 position, Quaternion rotation, bool inmediate)
         {
             if (entity == null)
                 return;

unity-renderer/Assets/DCLPlugins/ECS7/ECSComponents/Transform/Handler/ECSTransformHandler.cs

@@ -92,6 +92,9 @@ public void OnComponentModelUpdated(IParcelScene scene, IDCLEntity entity, ECSTr
 
             if (scaleChange || rotationChange)
                 sbcInternalComponent.OnTransformScaleRotationChanged(scene, entity);
+
+            // Same AvatarShape interpolation used at DCLTransform from SDK6
+            entity.OnTransformChange?.Invoke(model.position, model.rotation);
         }
 
         private static void ProcessNewParent(IParcelScene scene, IDCLEntity entity, long parentId)

unity-renderer/Assets/DCLPlugins/ECS7/Systems/TweenSystem/ECSTweenSystem.cs

@@ -94,6 +94,9 @@ private void UpdateTweenComponentModel(KeyValueSetTriplet<IParcelScene, long, EC
 
             model.currentTime = currentTime;
             tweenInternalComponent.PutFor(scene, entityId, model);
+
+            // Same AvatarShape interpolation used at DCLTransform from SDK6
+            entity.OnTransformChange?.Invoke(model.transform.localPosition, model.transform.localRotation);
         }
 
         private void UpdateTransformComponent(IParcelScene scene, IDCLEntity entity, Transform entityTransform, ComponentWriter writer)

unity-renderer/Assets/DCLPlugins/ECS7/TestsUtils/ECS7TestEntity.cs

@@ -132,10 +132,10 @@ Action<object> IDCLEntity.OnNameChange
         set => throw new NotImplementedException();
     }
 
-    Action<object> IDCLEntity.OnTransformChange
+    Action<Vector3, Quaternion> IDCLEntity.OnTransformChange
     {
-        get => throw new NotImplementedException();
-        set => throw new NotImplementedException();
+        get;
+        set;
     }
 
     public Action<IDCLEntity, bool> OnOuterBoundariesChanged

unity-renderer/Assets/Scripts/MainScripts/DCL/AvatarSystem/Definitions/IAvatarMovementController.cs

@@ -15,13 +15,13 @@ public interface IAvatarMovementController
         /// </summary>
         /// <param name="avatarTransform"></param>
         void SetAvatarTransform(Transform avatarTransform);
-        
+
         /// <summary>
         /// This will report the change of the transform, so it can be reported to kernel accordingly
         /// </summary>
         /// <param name="position"></param>
         /// <param name="rotation"></param>
-        /// <param name="inmediate"></param>
-        void OnTransformChanged(in Vector3 position, in Quaternion rotation, bool inmediate);
+        /// <param name="immediate"></param>
+        void OnTransformChanged(Vector3 position, Quaternion rotation, bool immediate);
     }
-}
+}

unity-renderer/Assets/Scripts/MainScripts/DCL/Components/Avatar/AvatarMovementController.cs

@@ -94,20 +94,19 @@ private void OnWorldReposition(Vector3 current, Vector3 previous)
             AvatarTransform.position = PositionUtils.WorldToUnityPosition(currentWorldPosition);
         }
 
-        public void OnTransformChanged(object model)
+        public void OnTransformChanged(Vector3 newPosition, Quaternion newRotation)
         {
-            DCLTransform.Model transformModel = (DCLTransform.Model)model;
-            OnTransformChanged(transformModel.position, transformModel.rotation, false);
+            OnTransformChanged(newPosition, newRotation, false);
         }
 
-        public void OnTransformChanged(in Vector3 position, in Quaternion rotation, bool inmediate)
+        public void OnTransformChanged(Vector3 position, Quaternion rotation, bool immediate)
         {
             float characterMinHeight = DCLCharacterController.i.characterController.height * 0.5f;
 
             MoveTo(
                 new Vector3(position.x, Math.Max(position.y - characterMinHeight, -characterMinHeight), position.z), // To fix the "always flying" avatars issue, We report the chara's centered position but the body hast its pivot at its feet
                 rotation,
-                inmediate);
+                immediate);
         }
 
         public void MoveTo(Vector3 position, Quaternion rotation, bool immediate = false)

unity-renderer/Assets/Scripts/MainScripts/DCL/Components/Avatar/AvatarShape.cs

@@ -374,10 +374,9 @@ private void Update()
             }
         }
 
-        private void OnEntityTransformChanged(object newModel)
+        private void OnEntityTransformChanged(Vector3 newPosition, Quaternion newRotation)
         {
-            DCLTransform.Model newTransformModel = (DCLTransform.Model)newModel;
-            OnEntityTransformChanged(newTransformModel.position, newTransformModel.rotation, !initializedPosition);
+            OnEntityTransformChanged(newPosition, newRotation, !initializedPosition);
         }
 
         private void OnEntityTransformChanged(in Vector3 position, in Quaternion rotation, bool inmediate)

unity-renderer/Assets/Scripts/MainScripts/DCL/Components/Transform/DCLTransform.cs

@@ -74,7 +74,7 @@ public void UpdateFromModel(BaseModel model)
             // and those values are used for the interpolation.
             if (entity.OnTransformChange != null)
             {
-                entity.OnTransformChange.Invoke(DCLTransform.model);
+                entity.OnTransformChange.Invoke(DCLTransform.model.position, DCLTransform.model.rotation);
             }
             else
             {

unity-renderer/Assets/Scripts/MainScripts/DCL/WorldRuntime/DecentralandEntity.cs

@@ -28,7 +28,7 @@ public class DecentralandEntity : IDCLEntity
         public Action<IDCLEntity> OnShapeUpdated { get; set; }
         public Action<IDCLEntity> OnShapeLoaded { get; set; }
         public Action<object> OnNameChange { get; set; }
-        public Action<object> OnTransformChange { get; set; }
+        public Action<Vector3, Quaternion> OnTransformChange { get; set; }
         public Action<IDCLEntity> OnRemoved { get; set; }
         public Action<IDCLEntity> OnMeshesInfoUpdated { get; set; }
         public Action<IDCLEntity> OnMeshesInfoCleaned { get; set; }

unity-renderer/Assets/Scripts/MainScripts/DCL/WorldRuntime/Interfaces/IDCLEntity.cs

@@ -31,7 +31,7 @@ public interface IDCLEntity : ICleanable, ICleanableEventDispatcher
         Action<CLASS_ID_COMPONENT, IDCLEntity> OnBaseComponentAdded { get; set; }
 
         Action<object> OnNameChange { get; set; }
-        Action<object> OnTransformChange { get; set; }
+        Action<Vector3, Quaternion> OnTransformChange { get; set; }
         Action<IDCLEntity, bool> OnInsideBoundariesChanged { get; set; }
         Action<IDCLEntity, bool> OnOuterBoundariesChanged { get; set; }
         long parentId { get; set; }