fix: context menu screen positioning (#5669)

Author: lorux0

unity-renderer/Assets/DCLFeatures/CameraReel/Gallery/Scripts/ThumbnailContextMenuView.cs

@@ -1,14 +1,14 @@
+using DCL.Helpers;
 using DCLServices.CameraReelService;
 using System;
-using System.Collections.Generic;
-using System.Linq;
+using UIComponents.ContextMenu;
 using UnityEngine;
-using UnityEngine.EventSystems;
 using UnityEngine.UI;
 
 namespace DCLFeatures.CameraReel.Gallery
 {
-    public class ThumbnailContextMenuView : MonoBehaviour, IThumbnailContextMenuView
+    [RequireComponent(typeof(RectTransform))]
+    public class ThumbnailContextMenuView : ContextMenuComponentView, IThumbnailContextMenuView
     {
         public static readonly BaseList<ThumbnailContextMenuView> Instances = new ();
 
@@ -24,23 +24,37 @@ public class ThumbnailContextMenuView : MonoBehaviour, IThumbnailContextMenuView
         public event Action OnShareToTwitterRequested;
         public event Action<CameraReelResponse> OnSetup;
 
-        private void Awake()
+        public override void Awake()
         {
+            base.Awake();
+
+            HidingHierarchyTransforms = new[]
+            {
+                transform,
+                downloadButton.transform,
+                deleteButton.transform,
+                copyLinkButton.transform,
+                shareToTwitterButton.transform,
+            };
+
             downloadButton.onClick.AddListener(() =>
             {
                 OnDownloadRequested?.Invoke();
                 Hide();
             });
+
             deleteButton.onClick.AddListener(() =>
             {
                 OnDeletePictureRequested?.Invoke();
                 Hide();
             });
+
             copyLinkButton.onClick.AddListener(() =>
             {
                 OnCopyPictureLinkRequested?.Invoke();
                 Hide();
             });
+
             shareToTwitterButton.onClick.AddListener(() =>
             {
                 OnShareToTwitterRequested?.Invoke();
@@ -55,43 +69,26 @@ private void OnDestroy()
             Instances.Remove(this);
         }
 
-        private void Update()
-        {
-            HideIfClickedOutside();
-        }
+        public override void RefreshControl() { }
 
         public void Show(CameraReelResponse picture)
         {
             gameObject.SetActive(true);
+            ClampPositionToScreenBorders(transform.position);
             OnSetup?.Invoke(picture);
         }
 
-        public void Dispose()
+        public override void Hide(bool instant = false)
         {
-            if (selfDestroy)
-                Destroy(gameObject);
-        }
+            base.Hide(instant);
 
-        private void Hide() =>
             gameObject.SetActive(false);
+        }
 
-        private void HideIfClickedOutside()
+        public override void Dispose()
         {
-            if (!Input.GetMouseButtonDown(0)) return;
-
-            var pointerEventData = new PointerEventData(EventSystem.current)
-            {
-                position = Input.mousePosition
-            };
-
-            var raycastResults = new List<RaycastResult>();
-            EventSystem.current.RaycastAll(pointerEventData, raycastResults);
-
-            if (raycastResults.All(result => result.gameObject != downloadButton.gameObject
-                && result.gameObject != deleteButton.gameObject
-                && result.gameObject != copyLinkButton.gameObject
-                && result.gameObject != shareToTwitterButton.gameObject))
-                Hide();
+            if (selfDestroy)
+                Utils.SafeDestroy(gameObject);
         }
     }
 }

unity-renderer/Assets/DCLPlugins/CameraReelPlugin/CameraReelPlugin.asmdef

@@ -20,7 +20,8 @@
         "GUID:1de3566cccb280f4a982c59ad0d08c96",
         "GUID:6426fc92c49cbb342916620a1009be8d",
         "GUID:fd6a19eb8dfe417a84a27e537222d98d",
-        "GUID:c34e38f41494f834abff029ddf82af43"
+        "GUID:c34e38f41494f834abff029ddf82af43",
+        "GUID:81f3218b29e049144b175dad2ebbac1b"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/FriendsHUD/Scripts/Tabs/FriendRequestsTabComponentView.cs

@@ -354,9 +354,9 @@ private void OnEntryCancelButtonPressed(FriendRequestEntry requestEntry)
 
     private void OnEntryMenuToggle(FriendEntryBase friendEntry)
     {
+        friendEntry.Dock(contextMenuPanel);
         contextMenuPanel.Show(friendEntry.Model.userId);
         contextMenuPanel.SetFriendshipContentActive(false);
-        friendEntry.Dock(contextMenuPanel);
     }
 
     private void UpdateCounterLabel()

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/FriendsHUD/Scripts/Tabs/FriendsTabComponentView.cs

@@ -380,8 +380,8 @@ private FriendEntry CreateEntry(string userId, Dictionary<string, PoolableObject
 
     private void OnEntryMenuToggle(FriendEntryBase friendEntry)
     {
-        contextMenuPanel.Show(friendEntry.Model.userId);
         friendEntry.Dock(contextMenuPanel);
+        contextMenuPanel.Show(friendEntry.Model.userId);
     }
 
     private Pool GetEntryPool()

unity-renderer/Assets/Scripts/MainScripts/DCL/Controllers/HUD/Mentions/Mentions.asmdef

@@ -9,7 +9,8 @@
         "GUID:f51ebe6a0ceec4240a699833d6309b23",
         "GUID:28f74c468a54948bfa9f625c5d428f56",
         "GUID:1e6b57fe78f7b724e9567f29f6a40c2c",
-        "GUID:2995626b54c60644988f134a69a77450"
+        "GUID:2995626b54c60644988f134a69a77450",
+        "GUID:81f3218b29e049144b175dad2ebbac1b"
     ],
     "includePlatforms": [],
     "excludePlatforms": [],