Bug: Hint was incorrectly suggesting 'mainImage()' could be inlined.

It can't, as it's a key function that usually can't be removed safely.

Author: DeanEdisGG

ShaderShrinker/Shrinker.Parser/Hinter.cs

@@ -48,7 +48,8 @@ public static IEnumerable<CodeHint> GetHints(this SyntaxNode rootNode)
         private static IEnumerable<CodeHint> DetectFunctionsToInline(SyntaxNode rootNode)
         {
             var localFunctions = rootNode.FunctionDefinitions().ToList();
-            foreach (var function in localFunctions)
+            var nonMainFunctions = localFunctions.Where(o => !o.IsMain()).ToList();
+            foreach (var function in nonMainFunctions)
             {
                 var callSites =
                     localFunctions
@@ -68,8 +69,8 @@ private static IEnumerable<CodeHint> DetectFunctionsToInline(SyntaxNode rootNode
 
         private static IEnumerable<CodeHint> DetectUnusedFunctionParam(SyntaxNode rootNode)
         {
-            var localFunctions = rootNode.FunctionDefinitions().ToList();
-            foreach (var function in localFunctions.Where(o => !o.IsMain()))
+            var localFunctions = rootNode.FunctionDefinitions().Where(o => !o.IsMain()).ToList();
+            foreach (var function in localFunctions)
             {
                 foreach (var paramName in function.ParamNames.Select(o => o.Token.Content))
                 {

ShaderShrinker/Shrinker.Parser/Optimizations/GolfExtensions.cs

@@ -13,6 +13,7 @@
 using System.Collections.Generic;
 using System.Linq;
 using Shrinker.Parser.SyntaxNodes;
+// ReSharper disable StringLiteralTypo
 
 namespace Shrinker.Parser.Optimizations
 {

ShaderShrinker/Shrinker.sln.DotSettings

@@ -652,6 +652,7 @@ namespace $NAMESPACE$
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=nums/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Plex/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=printrun/@EntryIndexedValue">True</s:Boolean>
+	<s:Boolean x:Key="/Default/UserDictionary/Words/=Renamable/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=screenpro/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Shadertoy/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/UserDictionary/Words/=Shrinker/@EntryIndexedValue">True</s:Boolean>

ShaderShrinker/UnitTests/GolfTests.cs

@@ -63,6 +63,7 @@ public void CheckGolfingCodeNames(
                        "void foo() { int a = 1; }|void f() { int a = 1; }",
                        "void foo() { int _a = 1; }|void f() { int a = 1; }",
                        "void main() { int number = 1; }|void main() { int n = 1; }",
+                       "void mainImage() { int number = 1; }|void mainImage() { int n = 1; }",
                        "int foo() { int number = 1; number++; return number; }|int f() { int n = 1; n++; return n; }",
                        "int foo() { int number = 1; return ++number; }|int f() { int n = 1; return ++n; }",
                        "int foo() { int number = 1; return number++; }|int f() { int n = 1; return n++; }",

ShaderShrinker/UnitTests/HinterTests.cs

@@ -42,6 +42,17 @@ public void CheckDetectingFunctionToInline()
             Assert.That(rootNode.GetHints().OfType<FunctionToInlineHint>().ToList(), Has.Count.EqualTo(1));
         }
 
+        [Test]
+        public void CheckInlineHintNotGivenForMainFunctions()
+        {
+            var lexer = new Lexer();
+            lexer.Load("vec3 mainImage() { return vec3(0); } vec3 main() { return mainImage(); }");
+
+            var rootNode = new Parser(lexer).Parse();
+
+            Assert.That(rootNode.GetHints().OfType<FunctionToInlineHint>().ToList(), Is.Empty);
+        }
+
         [Test, Sequential]
         public void CheckDetectingFunctionWithUnusedParam(
             [Values(