Feature: New hint - More #define GOLF suggestions.

Author: DeanEdisGG

ShaderShrinker/Shrinker.Parser/Hinter.cs

@@ -76,8 +76,8 @@ private static IEnumerable<CodeHint> DetectUnusedFunctionParam(SyntaxNode rootNo
 
         private static IEnumerable<CodeHint> DetectDefinableReferences(SyntaxNode rootNode)
         {
-            var candidates = new[] { "smoothstep", "iResolution", "normalize" };
-            var replacement = new[] { "S smoothstep", "R iResolution", "N normalize" };
+            var candidates = new[] { "smoothstep", "iResolution", "normalize", "iTime", "iMouse" };
+            var replacement = new[] { "S smoothstep", "R iResolution", "N normalize", "T time", "M iMouse" };
             var usages = rootNode.TheTree
                 .Select(o => o.Token?.Content ?? (o as FunctionCallSyntaxNode)?.Name)
                 .Where(o => candidates.Any(o.StartsWithVarName))
@@ -86,7 +86,7 @@ private static IEnumerable<CodeHint> DetectDefinableReferences(SyntaxNode rootNo
             {
                 var usageCount = usages.Count(o => o.StartsWithVarName(candidate));
                 var oldSize = candidate.Length * usageCount;
-                var newSize = 8 + candidate.Length + usageCount + usageCount;
+                var newSize = 8 + candidate.Length + usageCount;
 
                 if (newSize < oldSize)
                     yield return new IntroduceDefine(candidate, replacement[candidates.ToList().IndexOf(candidate)]);

ShaderShrinker/UnitTests/HinterTests.cs

@@ -72,7 +72,7 @@ public void CheckSingleUseResolutionDoesNotTriggerHint()
         }
 
         [Test]
-        public void CheckMultiUseResolutionDoesNotTriggerHint()
+        public void CheckMultiUseResolutionTriggersHint()
         {
             var lexer = new Lexer();
             lexer.Load("float main() { return iResolution.x + iResolution.y + iResolution.y; }");
@@ -94,7 +94,7 @@ public void CheckSingleUseSmoothstepDoesNotTriggerHint()
         }
 
         [Test]
-        public void CheckMultiUseSmoothstepDoesNotTriggerHint()
+        public void CheckMultiUseSmoothstepTriggersHint()
         {
             var lexer = new Lexer();
             lexer.Load("float main() { return smoothstep(0.0, 1.0, smoothstep(0.0, 1.0, smoothstep(0.0, 1.0, 0.5))); }");
@@ -103,5 +103,27 @@ public void CheckMultiUseSmoothstepDoesNotTriggerHint()
 
             Assert.That(() => rootNode.GetHints().OfType<Hinter.IntroduceDefine>().ToList(), Has.Count.EqualTo(1));
         }
+
+        [Test]
+        public void CheckSingleUseMouseDoesNotTriggerHint()
+        {
+            var lexer = new Lexer();
+            lexer.Load("float main() { return iMouse.x; }");
+
+            var rootNode = new Parser(lexer).Parse();
+
+            Assert.That(() => rootNode.GetHints(), Is.Empty);
+        }
+
+        [Test]
+        public void CheckMultiUseMouseTriggersHint()
+        {
+            var lexer = new Lexer();
+            lexer.Load("float main() { return iMouse.x + iMouse.y * iMouse.z; }");
+
+            var rootNode = new Parser(lexer).Parse();
+
+            Assert.That(() => rootNode.GetHints().OfType<Hinter.IntroduceDefine>().ToList(), Has.Count.EqualTo(1));
+        }
     }
 }