Fix: Allow parsing of function definitions containing params with no param names.

E.g. void myFunc(int, int);

Author: DeanEdisGG

ShaderShrinker/Shrinker.Parser/SyntaxNodes/FunctionSyntaxNodeBase.cs

@@ -30,9 +30,9 @@ public List<GenericSyntaxNode> ParamNames
             {
                 if (!Params.Children.Any())
                     return new List<GenericSyntaxNode>();
-                var children = Params.Children.OfType<GenericSyntaxNode>().Where(o => o.Token is AlphaNumToken || o.Token is CommaToken).Append(new GenericSyntaxNode(new CommaToken())).ToList();
+                var children = Params.Children.OfType<GenericSyntaxNode>().Where(o => o.Token is AlphaNumToken or CommaToken).Append(new GenericSyntaxNode(new CommaToken())).ToList();
                 var commaIndexes = children.Where(o => o.Token is CommaToken).Select(o => children.IndexOf(o));
-                return commaIndexes.Select(i => children[i - 1]).ToList();
+                return commaIndexes.Where(i => i > 0 && children[i - 1].Token is not CommaToken).Select(i => children[i - 1]).ToList();
             }
         }
 

ShaderShrinker/UnitTests/ShrinkerTests.cs

@@ -621,11 +621,13 @@ public void CheckFunctionDeclarationsWithoutDefinitionsAreRemoved()
             Assert.That(rootNode.ToCode().ToSimple(), Is.EqualTo("void main() { }"));
         }
 
-        [Test]
-        public void CheckFunctionDeclarationParamNamesAreRemoved()
+        [Test, Sequential]
+        public void CheckFunctionDeclarationParamNamesAreRemoved(
+            [Values("void foo(int a, int b); void main() { foo(1, 2); } void foo(int a, int b) { }",
+                    "void foo(int, int); void main() { foo(1, 2); } void foo(int a, int b) { }")] string code)
         {
             var lexer = new Lexer();
-            lexer.Load("void foo(int a, int b); void main() { foo(1, 2); } void foo(int a, int b) { }");
+            lexer.Load(code);
 
             var options = CustomOptions.None();
             options.SimplifyFunctionDeclarations = true;