updated tests for contacts resource

Author: dcblogdev

src/Resources/Contacts.php

@@ -49,9 +49,9 @@ protected function getParams(array $params, int $perPage): string
     {
         $skip = $params['skip'] ?? 0;
         $page = request('p', $skip);
-        if ($page > 0) {
-            $page--;
-        }
+//        if ($page > 0) {
+//            $page--;
+//        }
 
         if ($params == []) {
             $params = http_build_query([
@@ -62,15 +62,15 @@ protected function getParams(array $params, int $perPage): string
             ]);
         } else {
             // ensure $top, $skip and $count are part of params
-            if (! in_array('$top', $params)) {
+            if (! array_key_exists('$top', $params)) {
                 $params['$top'] = $perPage;
             }
 
-            if (! in_array('$skip', $params)) {
+            if (! array_key_exists('$skip', $params)) {
                 $params['$skip'] = $page;
             }
 
-            if (! in_array('$count', $params)) {
+            if (! array_key_exists('$count', $params)) {
                 $params['$count'] = 'true';
             }
 

tests/Resources/ContactsTest.php

@@ -34,6 +34,64 @@
         ->and($response['total'])->toBe(10);
 });
 
+test('getParams returns default values when no params provided', function () {
+
+    $contacts = new Contacts();
+    $reflection = new ReflectionMethod(Contacts::class, 'getParams');
+    $response = $reflection->invoke($contacts, [], 25);
+
+    parse_str($response, $parsedParams);
+
+    expect($parsedParams)->toMatchArray([
+        '$orderby' => 'displayName',
+        '$top' => '25',
+        '$skip' => '0',
+        '$count' => 'true',
+    ]);
+});
+
+test('getParams includes custom top parameter', function () {
+    $contacts = new Contacts();
+    $reflection = new ReflectionMethod(Contacts::class, 'getParams');
+    $response = $reflection->invoke($contacts, ['$top' => 10], 25);
+
+    parse_str($response, $parsedParams);
+
+    expect($parsedParams)->toMatchArray([
+        '$top' => '10',
+        '$skip' => '0',
+        '$count' => 'true',
+    ]);
+});
+
+test('getParams includes custom skip parameter', function () {
+    $contacts = new Contacts();
+    $reflection = new ReflectionMethod(Contacts::class, 'getParams');
+    $response = $reflection->invoke($contacts, ['$skip' => 15], 25);
+
+    parse_str($response, $parsedParams);
+
+    expect($parsedParams)->toMatchArray([
+        '$top' => '25',
+        '$skip' => '15',
+        '$count' => 'true',
+    ]);
+});
+
+test('getParams forces count to be true when missing', function () {
+    $contacts = new Contacts();
+    $reflection = new ReflectionMethod(Contacts::class, 'getParams');
+    $response = $reflection->invoke($contacts, ['$top' => 10, '$skip' => 5], 25);
+
+    parse_str($response, $parsedParams);
+
+    expect($parsedParams)->toMatchArray([
+        '$top' => '10',
+        '$skip' => '5',
+        '$count' => 'true',
+    ]);
+});
+
 test('find method retrieves a specific contact', function () {
 
     MsGraph::shouldReceive('get')