From 2db99d3ca40bb5dd430650792d1f959a011c314c Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Wed, 19 Oct 2022 06:15:25 +0200 Subject: [PATCH 1/3] chore: template simplification we obviously only need the condition around the table cell head element --- .../_patterns/02-components/table/table.hbs | 24 ++++++------------- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/source/_patterns/02-components/table/table.hbs b/source/_patterns/02-components/table/table.hbs index 50663fd6579..0ffb0fa0462 100644 --- a/source/_patterns/02-components/table/table.hbs +++ b/source/_patterns/02-components/table/table.hbs @@ -16,22 +16,12 @@ - {{! TODO: Not elegant, but working for the moment… }} - {{#if rowtitle }} - {{#each cells }} - - table header - {{{ text01 }}} - {{{ text02 }}} - - {{/each }} - {{else}} - {{#each cells }} - - {{{ text01 }}} - {{{ text02 }}} - - {{/each }} - {{/if }} + {{#each cells }} + + {{#if ../rowtitle }}table header{{/if }} + {{{ text01 }}} + {{{ text02 }}} + + {{/each }} From e3a2f1f1e0e9101dd71b28c0a54e3cadbf5b1818 Mon Sep 17 00:00:00 2001 From: Maximilian Franzke Date: Thu, 20 Oct 2022 11:26:59 +0200 Subject: [PATCH 2/3] feat: providing a table overflow-menu usage example --- source/_patterns/02-components/overflow-menu/overflow-menu.hbs | 2 +- .../_patterns/02-components/overflow-menu/overflow-menu.json | 1 - .../overflow-menu/overflow-menu~opposite-position.json | 1 - source/_patterns/02-components/table/table.hbs | 1 + source/_patterns/02-components/table/table~overflow-menu.json | 3 +++ 5 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 source/_patterns/02-components/table/table~overflow-menu.json diff --git a/source/_patterns/02-components/overflow-menu/overflow-menu.hbs b/source/_patterns/02-components/overflow-menu/overflow-menu.hbs index 01a4d9d8867..0b7d74ec935 100644 --- a/source/_patterns/02-components/overflow-menu/overflow-menu.hbs +++ b/source/_patterns/02-components/overflow-menu/overflow-menu.hbs @@ -1,4 +1,4 @@ -