Fix access notice

daun · daun · commit eaa3636f6083 · 2022-09-20T19:25:44.000+02:00
diff --git a/DashboardPanelShortcuts.module b/DashboardPanelShortcuts.module
@@ -109,7 +109,7 @@ class DashboardPanelShortcuts extends DashboardPanel
             }
         }
 
-        if ($page && $this->isPageViewable($page)) {
+        if (is_object($page) && $this->isPageViewable($page)) {
             $info = $this->getPageInfo($page);
             $title = $title ?? (is_string($key) ? $key : $info->title);
             $summary = $summary ?? $info->summary;
@@ -223,7 +223,7 @@ class DashboardPanelShortcuts extends DashboardPanel
 
     protected function isPageViewable($page)
     {
-        if (!$page || !$page->url) {
+        if (!($page->url ?? null)) {
             return false;
         }
         if (!$this->checkAccess) {

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ class DashboardPanelShortcuts extends DashboardPanel`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
`112`		`- if ($page && $this->isPageViewable($page)) {`
	`112`	`+ if (is_object($page) && $this->isPageViewable($page)) {`
`113`	`113`	`$info = $this->getPageInfo($page);`
`114`	`114`	`$title = $title ?? (is_string($key) ? $key : $info->title);`
`115`	`115`	`$summary = $summary ?? $info->summary;`
`@@ -223,7 +223,7 @@ class DashboardPanelShortcuts extends DashboardPanel`
`223`	`223`
`224`	`224`	`protected function isPageViewable($page)`
`225`	`225`	`{`
`226`		`- if (!$page \|\| !$page->url) {`
	`226`	`+ if (!($page->url ?? null)) {`
`227`	`227`	`return false;`
`228`	`228`	`}`
`229`	`229`	`if (!$this->checkAccess) {`