Handle JDBC passwords containing special chars #2146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
+ Coverage 65.10% 65.14% +0.04%
==========================================
Files 100 100
Lines 8493 8503 +10
Branches 884 885 +1
==========================================
+ Hits 5529 5539 +10
Misses 2774 2774
Partials 190 190 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 11 flaky, 3m50s total Flaky tests:
Running from acceptance #3122 |
m-abulazm
force-pushed
the
fix/recon/jdbc_password
branch
from
a68f6d9 to
c0c2054
Compare
m-abulazm
force-pushed
the
fix/recon/jdbc_password
branch
from
b23b721 to
6223d21
Compare
asnare
changed the title
asnare
reviewed
Dec 1, 2025
| connector = TSQLServerDataSourceUnderTest(mock_spark, mock_ws) | ||
|
|
||
| columns = connector.get_schema("labs_azure_sandbox_remorph", "dbo", "Employees") | ||
| columns = connector.get_schema("labs_azure_sandbox_remorph", "dbo", "reconcile_in") |
Contributor
Author
There was a problem hiding this comment.
manually created by me.
| } | ||
|
|
||
| def reader(self, query: str) -> DataFrameReader: | ||
| def reader(self, query: str, options: dict | None = None) -> DataFrameReader: |
Contributor
There was a problem hiding this comment.
Suggested change
| def reader(self, query: str, options: dict | None = None) -> DataFrameReader: | |
| def reader(self, query: str, options: Mapping[str, OptionalPrimitiveType] | None = None) -> DataFrameReader: |
Contributor
Author
There was a problem hiding this comment.
I cant import OptionalPrimitiveType so using object
Contributor
There was a problem hiding this comment.
Try:
from pyspark.sql.readwriter import OptionalPrimitiveType
Contributor
Author
There was a problem hiding this comment.
this cannot be imported as well. I copied it so we can use it.
asnare
reviewed
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
Relevant implementation details