-
Notifications
You must be signed in to change notification settings - Fork 74
Updated dashboards deployment to use standard lakeview dashboard definitions #950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…place of lsql library
|
✅ 445/445 passed, 3 flaky, 40 skipped, 5h25m32s total Flaky tests:
Running from acceptance #3315 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
+ Coverage 90.09% 90.20% +0.11%
==========================================
Files 64 64
Lines 6138 6188 +50
==========================================
+ Hits 5530 5582 +52
+ Misses 608 606 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates dashboard configuration from a YAML-based format using the lsql library to a native JSON-based Lakeview dashboard definition format. The change standardizes dashboard creation to use Databricks SDK's native Lakeview API directly.
Key Changes:
- Replaced YAML dashboard configuration with JSON format
- Implemented custom
DashboardMetadataclass to replace thelsqllibrary dependency - Refactored
DashboardInstallerto use native Lakeview SDK methods for dashboard creation and publishing
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/databricks/labs/dqx/queries/quality/dashboard/dashboard.yml |
Removed legacy YAML dashboard configuration |
src/databricks/labs/dqx/queries/quality/dashboard/dashboard.json |
Added new JSON-based dashboard configuration with native Lakeview format |
src/databricks/labs/dqx/installer/dashboard_installer.py |
Replaced lsql library with custom implementation using native Databricks SDK Lakeview API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/databricks/labs/dqx/queries/quality/dashboard/dashboard.json
Outdated
Show resolved
Hide resolved
mwojtyczka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls also remove databricks-labs-lsql from the dependencies in pyproject.toml
Done |
updated tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes
lsqldependency.Linked issues
Resolves #132
Tests