From 40ccd02691dab23fce4d690e42d4915ba01877ce Mon Sep 17 00:00:00 2001 From: hanzala-Databrain Date: Fri, 29 Aug 2025 12:27:29 +0530 Subject: [PATCH 1/3] fix: path name --- .github/workflows/DuckDBNodeBindingsAndAPI.yml | 10 +++++----- api/pkgs/{@duckdb => @databrainhq}/node-api/.npmignore | 0 api/pkgs/{@duckdb => @databrainhq}/node-api/README.md | 0 .../{@duckdb => @databrainhq}/node-api/package.json | 0 api/pkgs/@duckdb/node-api/.npmrc | 1 - 5 files changed, 5 insertions(+), 6 deletions(-) rename api/pkgs/{@duckdb => @databrainhq}/node-api/.npmignore (100%) rename api/pkgs/{@duckdb => @databrainhq}/node-api/README.md (100%) rename api/pkgs/{@duckdb => @databrainhq}/node-api/package.json (100%) delete mode 100644 api/pkgs/@duckdb/node-api/.npmrc diff --git a/.github/workflows/DuckDBNodeBindingsAndAPI.yml b/.github/workflows/DuckDBNodeBindingsAndAPI.yml index 5397bf17..4d67c76b 100644 --- a/.github/workflows/DuckDBNodeBindingsAndAPI.yml +++ b/.github/workflows/DuckDBNodeBindingsAndAPI.yml @@ -87,7 +87,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: '20' - registry-url: 'https://npm.pkg.github.com/' + registry-url: 'https://registry.npmjs.org/' - uses: pnpm/action-setup@v3 with: version: 9 @@ -160,7 +160,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: '20' - registry-url: 'https://npm.pkg.github.com/' + registry-url: 'https://registry.npmjs.org/' - uses: pnpm/action-setup@v3 with: @@ -197,7 +197,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: '20' - registry-url: 'https://npm.pkg.github.com/' + registry-url: 'https://registry.npmjs.org/' - uses: pnpm/action-setup@v3 with: @@ -246,7 +246,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: '20' - registry-url: 'https://npm.pkg.github.com/' + registry-url: 'https://registry.npmjs.org/' - uses: pnpm/action-setup@v3 with: version: 9 @@ -294,7 +294,7 @@ jobs: uses: actions/setup-node@v4 with: node-version: '20' - registry-url: 'https://npm.pkg.github.com/' + registry-url: 'https://registry.npmjs.org/' - uses: pnpm/action-setup@v3 with: diff --git a/api/pkgs/@duckdb/node-api/.npmignore b/api/pkgs/@databrainhq/node-api/.npmignore similarity index 100% rename from api/pkgs/@duckdb/node-api/.npmignore rename to api/pkgs/@databrainhq/node-api/.npmignore diff --git a/api/pkgs/@duckdb/node-api/README.md b/api/pkgs/@databrainhq/node-api/README.md similarity index 100% rename from api/pkgs/@duckdb/node-api/README.md rename to api/pkgs/@databrainhq/node-api/README.md diff --git a/api/pkgs/@duckdb/node-api/package.json b/api/pkgs/@databrainhq/node-api/package.json similarity index 100% rename from api/pkgs/@duckdb/node-api/package.json rename to api/pkgs/@databrainhq/node-api/package.json diff --git a/api/pkgs/@duckdb/node-api/.npmrc b/api/pkgs/@duckdb/node-api/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/api/pkgs/@duckdb/node-api/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file From 06e5cc3c9a1d189eb763281381acfe9b698e8769 Mon Sep 17 00:00:00 2001 From: hanzala-Databrain Date: Fri, 29 Aug 2025 12:27:41 +0530 Subject: [PATCH 2/3] fix: remove npmrc --- bindings/pkgs/@databrainhq/node-bindings-darwin-arm64/.npmrc | 1 - bindings/pkgs/@databrainhq/node-bindings-darwin-x64/.npmrc | 1 - bindings/pkgs/@databrainhq/node-bindings-linux-arm64/.npmrc | 1 - bindings/pkgs/@databrainhq/node-bindings-linux-x64/.npmrc | 1 - bindings/pkgs/@databrainhq/node-bindings-win32-x64/.npmrc | 1 - bindings/pkgs/@databrainhq/node-bindings/.npmrc | 1 - 6 files changed, 6 deletions(-) delete mode 100644 bindings/pkgs/@databrainhq/node-bindings-darwin-arm64/.npmrc delete mode 100644 bindings/pkgs/@databrainhq/node-bindings-darwin-x64/.npmrc delete mode 100644 bindings/pkgs/@databrainhq/node-bindings-linux-arm64/.npmrc delete mode 100644 bindings/pkgs/@databrainhq/node-bindings-linux-x64/.npmrc delete mode 100644 bindings/pkgs/@databrainhq/node-bindings-win32-x64/.npmrc delete mode 100644 bindings/pkgs/@databrainhq/node-bindings/.npmrc diff --git a/bindings/pkgs/@databrainhq/node-bindings-darwin-arm64/.npmrc b/bindings/pkgs/@databrainhq/node-bindings-darwin-arm64/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/bindings/pkgs/@databrainhq/node-bindings-darwin-arm64/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file diff --git a/bindings/pkgs/@databrainhq/node-bindings-darwin-x64/.npmrc b/bindings/pkgs/@databrainhq/node-bindings-darwin-x64/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/bindings/pkgs/@databrainhq/node-bindings-darwin-x64/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file diff --git a/bindings/pkgs/@databrainhq/node-bindings-linux-arm64/.npmrc b/bindings/pkgs/@databrainhq/node-bindings-linux-arm64/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/bindings/pkgs/@databrainhq/node-bindings-linux-arm64/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file diff --git a/bindings/pkgs/@databrainhq/node-bindings-linux-x64/.npmrc b/bindings/pkgs/@databrainhq/node-bindings-linux-x64/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/bindings/pkgs/@databrainhq/node-bindings-linux-x64/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file diff --git a/bindings/pkgs/@databrainhq/node-bindings-win32-x64/.npmrc b/bindings/pkgs/@databrainhq/node-bindings-win32-x64/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/bindings/pkgs/@databrainhq/node-bindings-win32-x64/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file diff --git a/bindings/pkgs/@databrainhq/node-bindings/.npmrc b/bindings/pkgs/@databrainhq/node-bindings/.npmrc deleted file mode 100644 index 2346004a..00000000 --- a/bindings/pkgs/@databrainhq/node-bindings/.npmrc +++ /dev/null @@ -1 +0,0 @@ -//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN} \ No newline at end of file From 226b766ee6089da8b2e8e0fb10d75304c48c761f Mon Sep 17 00:00:00 2001 From: hanzala-Databrain Date: Fri, 29 Aug 2025 12:33:45 +0530 Subject: [PATCH 3/3] fix: npm token --- .../workflows/DuckDBNodeBindingsAndAPI.yml | 318 +++++++++--------- 1 file changed, 156 insertions(+), 162 deletions(-) diff --git a/.github/workflows/DuckDBNodeBindingsAndAPI.yml b/.github/workflows/DuckDBNodeBindingsAndAPI.yml index 4d67c76b..e2ce33a8 100644 --- a/.github/workflows/DuckDBNodeBindingsAndAPI.yml +++ b/.github/workflows/DuckDBNodeBindingsAndAPI.yml @@ -116,173 +116,167 @@ jobs: run: git status - name: Publish - Bindings - Linux x64 - if: ${{ inputs.publish }} - working-directory: bindings/pkgs/@databrainhq/node-bindings-linux-x64 - run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} - env: - NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - - name: Publish - Bindings - if: ${{ inputs.publish }} - working-directory: bindings/pkgs/@databrainhq/node-bindings - run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} - env: - NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - - name: Publish - API - if: ${{ inputs.publish }} - working-directory: api/pkgs/@databrainhq/node-api - run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} - env: - NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - linux_arm64: - name: Linux arm64 - runs-on: ubuntu-latest - if: ${{ inputs.linux_arm64 }} - env: - TARGET_ARCH: arm64 - CC: aarch64-linux-gnu-gcc - CXX: aarch64-linux-gnu-g++ - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - steps: - - name: Install aarch64 compilers - run: sudo apt-get update && sudo apt install binutils-aarch64-linux-gnu gcc-aarch64-linux-gnu g++-aarch64-linux-gnu - - - name: Checkout code - uses: actions/checkout@v4 - - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: '20' - registry-url: 'https://registry.npmjs.org/' - - - uses: pnpm/action-setup@v3 + - uses: JS-DevTools/npm-publish@v2 with: - version: 9 - - - name: Workspace - Install - run: pnpm install --ignore-scripts - - - name: Bindings - Build - working-directory: bindings - run: pnpm run build - - - name: Git Status - if: ${{ inputs.publish }} - run: git status - - - name: Publish - Bindings - Linux arm64 - if: ${{ inputs.publish }} - working-directory: bindings/pkgs/@databrainhq/node-bindings-linux-arm64 - run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} - env: - NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - macos_arm64: - name: Mac OS X arm64 - runs-on: macos-latest - if: ${{ inputs.macos_arm64 }} - steps: - - name: Checkout code - uses: actions/checkout@v4 + token: ${{ secrets.DUCKDB_NPM_TOKEN }} + package: bindings/pkgs/@databrainhq/node-bindings-linux-x64 - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: '20' - registry-url: 'https://registry.npmjs.org/' - - - uses: pnpm/action-setup@v3 + - name: Publish - Bindings + - uses: JS-DevTools/npm-publish@v2 with: - version: 9 - - - name: Workspace - Install - run: pnpm install --ignore-scripts + token: ${{ secrets.DUCKDB_NPM_TOKEN }} + package: bindings/pkgs/@databrainhq/node-bindings - - name: Bindings - Build - working-directory: bindings - run: pnpm run build - - - name: Bindings - Test - working-directory: bindings - run: pnpm test - - - name: API - Build - working-directory: api - run: pnpm run build - - # - name: API - Test - # working-directory: api - # run: pnpm test - - - name: Git Status - if: ${{ inputs.publish }} - run: git status - - - name: Publish - Bindings - Darwin arm64 - if: ${{ inputs.publish }} - working-directory: bindings/pkgs/@databrainhq/node-bindings-darwin-arm64 - run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} - env: - NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - macos_x64: - name: Mac OS X x64 - runs-on: macos-13 - if: ${{ inputs.macos_x64 }} - steps: - - name: Checkout code - uses: actions/checkout@v4 - - - name: Setup Node.js - uses: actions/setup-node@v4 - with: - node-version: '20' - registry-url: 'https://registry.npmjs.org/' - - uses: pnpm/action-setup@v3 + - name: Publish - API + - uses: JS-DevTools/npm-publish@v2 with: - version: 9 - - - name: Workspace - Install - run: pnpm install --ignore-scripts - - - name: Bindings - Build - working-directory: bindings - run: pnpm run build - - - name: Bindings - Test - working-directory: bindings - run: pnpm test - - - name: API - Build - working-directory: api - run: pnpm run build - - # - name: API - Test - # working-directory: api - # run: pnpm test - - - name: Git Status - if: ${{ inputs.publish }} - run: git status - - - name: Publish - Bindings - Darwin x64 - if: ${{ inputs.publish }} - working-directory: bindings/pkgs/@databrainhq/node-bindings-darwin-x64 - run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} - env: - NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} - YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} - - windows_x64: + token: ${{ secrets.DUCKDB_NPM_TOKEN }} + package: api/pkgs/@databrainhq/node-api + + # linux_arm64: + # name: Linux arm64 + # runs-on: ubuntu-latest + # if: ${{ inputs.linux_arm64 }} + # env: + # TARGET_ARCH: arm64 + # CC: aarch64-linux-gnu-gcc + # CXX: aarch64-linux-gnu-g++ + # YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} + + # steps: + # - name: Install aarch64 compilers + # run: sudo apt-get update && sudo apt install binutils-aarch64-linux-gnu gcc-aarch64-linux-gnu g++-aarch64-linux-gnu + + # - name: Checkout code + # uses: actions/checkout@v4 + + # - name: Setup Node.js + # uses: actions/setup-node@v4 + # with: + # node-version: '20' + # registry-url: 'https://registry.npmjs.org/' + + # - uses: pnpm/action-setup@v3 + # with: + # version: 9 + + # - name: Workspace - Install + # run: pnpm install --ignore-scripts + + # - name: Bindings - Build + # working-directory: bindings + # run: pnpm run build + + # - name: Git Status + # if: ${{ inputs.publish }} + # run: git status + + # - name: Publish - Bindings - Linux arm64 + # if: ${{ inputs.publish }} + # working-directory: bindings/pkgs/@databrainhq/node-bindings-linux-arm64 + # run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} + # env: + # NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} + # YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} + + # macos_arm64: + # name: Mac OS X arm64 + # runs-on: macos-latest + # if: ${{ inputs.macos_arm64 }} + # steps: + # - name: Checkout code + # uses: actions/checkout@v4 + + # - name: Setup Node.js + # uses: actions/setup-node@v4 + # with: + # node-version: '20' + # registry-url: 'https://registry.npmjs.org/' + + # - uses: pnpm/action-setup@v3 + # with: + # version: 9 + + # - name: Workspace - Install + # run: pnpm install --ignore-scripts + + # - name: Bindings - Build + # working-directory: bindings + # run: pnpm run build + + # - name: Bindings - Test + # working-directory: bindings + # run: pnpm test + + # - name: API - Build + # working-directory: api + # run: pnpm run build + + # # - name: API - Test + # # working-directory: api + # # run: pnpm test + + # - name: Git Status + # if: ${{ inputs.publish }} + # run: git status + + # - name: Publish - Bindings - Darwin arm64 + # if: ${{ inputs.publish }} + # working-directory: bindings/pkgs/@databrainhq/node-bindings-darwin-arm64 + # run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} + # env: + # NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} + # YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} + + # macos_x64: + # name: Mac OS X x64 + # runs-on: macos-13 + # if: ${{ inputs.macos_x64 }} + # steps: + # - name: Checkout code + # uses: actions/checkout@v4 + + # - name: Setup Node.js + # uses: actions/setup-node@v4 + # with: + # node-version: '20' + # registry-url: 'https://registry.npmjs.org/' + # - uses: pnpm/action-setup@v3 + # with: + # version: 9 + + # - name: Workspace - Install + # run: pnpm install --ignore-scripts + + # - name: Bindings - Build + # working-directory: bindings + # run: pnpm run build + + # - name: Bindings - Test + # working-directory: bindings + # run: pnpm test + + # - name: API - Build + # working-directory: api + # run: pnpm run build + + # # - name: API - Test + # # working-directory: api + # # run: pnpm test + + # - name: Git Status + # if: ${{ inputs.publish }} + # run: git status + + # - name: Publish - Bindings - Darwin x64 + # if: ${{ inputs.publish }} + # working-directory: bindings/pkgs/@databrainhq/node-bindings-darwin-x64 + # run: pnpm publish ${{ inputs.publish_dry_run && '--dry-run' || '' }} --publish-branch ${{ github.ref_name }} + # env: + # NPM_AUTH_TOKEN: ${{ secrets.DUCKDB_NPM_TOKEN }} + # YOUR_USERNAME: ${{ secrets.YOUR_USERNAME }} + + # windows_x64: name: Windows x64 runs-on: windows-latest if: ${{ inputs.windows_x64 }}