Skip to content

Commit e82253b

Browse files
committed
review fixes
1 parent 5b216cb commit e82253b

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

delta-plugins-common/src/main/java/io/cdap/delta/plugin/common/DriverCleanup.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public static DriverCleanup ensureJDBCDriverIsAvailable(Class<? extends Driver>
6262
try {
6363
deregisterAllDrivers(classz);
6464
} catch (NoSuchFieldException | ClassNotFoundException e1) {
65-
LOG.warn("Unable to deregister JDBC Driver class {} {}", classz, e1.getMessage());
65+
LOG.warn("Unable to deregister JDBC Driver class {}", classz, e1);
6666
}
6767
DriverManager.registerDriver(shim);
6868
return new DriverCleanup(shim);

sqlserver-delta-plugins/src/main/java/io/cdap/delta/sqlserver/SqlServerTableRegistry.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
* Sql Server table registry
5353
*/
5454
public class SqlServerTableRegistry implements TableRegistry {
55-
private static final Logger LOGGER = LoggerFactory.getLogger(SqlServerTableRegistry.class);
55+
private static final Logger LOG = LoggerFactory.getLogger(SqlServerTableRegistry.class);
5656
private final String jdbcUrl;
5757
private final SqlServerConfig config;
5858
private final DriverCleanup driverCleanup;
@@ -136,7 +136,7 @@ public TableDetail describeTable(String db, @Nullable String schema, String tabl
136136
} catch (Exception e) {
137137
String msg = String.format("Unable to check if CDC feature for table '%s' in database '%s' was enabled or not",
138138
schema == null ? table : schema + "." + table, db);
139-
LOGGER.error(msg, e);
139+
LOG.error(msg, e);
140140
missingFeatures.add(
141141
new Problem("Unable To Check If CDC Was Enabled", msg,
142142
"Check database connectivity and table information", null));
@@ -192,11 +192,11 @@ private Optional<TableDetail.Builder> getTableDetailBuilder(DatabaseMetaData dbM
192192
return Optional.empty();
193193
}
194194
List<String> primaryKey = new ArrayList<>();
195-
LOGGER.debug("Query primary key for {}.{}.{}", db, schema, table);
195+
LOG.debug("Query primary key for {}.{}.{}", db, schema, table);
196196
try (ResultSet keyResults = dbMeta.getPrimaryKeys(db, schema, table)) {
197197
while (keyResults.next()) {
198198
String pk = keyResults.getString("COLUMN_NAME");
199-
LOGGER.debug("Found primary key for {}.{}.{} : {}", db, schema, table, pk);
199+
LOG.debug("Found primary key for {}.{}.{} : {}", db, schema, table, pk);
200200
primaryKey.add(pk);
201201
}
202202
}

0 commit comments

Comments
 (0)