diff --git a/bricks/create_dart_frog/hooks/analysis_options.yaml b/bricks/create_dart_frog/hooks/analysis_options.yaml index bb7209144..9df80aa49 100644 --- a/bricks/create_dart_frog/hooks/analysis_options.yaml +++ b/bricks/create_dart_frog/hooks/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.6.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml diff --git a/bricks/create_dart_frog/hooks/pubspec.yaml b/bricks/create_dart_frog/hooks/pubspec.yaml index 6097b6958..a214525b3 100644 --- a/bricks/create_dart_frog/hooks/pubspec.yaml +++ b/bricks/create_dart_frog/hooks/pubspec.yaml @@ -4,10 +4,10 @@ environment: sdk: ">=3.0.0 <4.0.0" dependencies: - mason: ^0.1.0-dev.39 + mason: ^0.1.0 path: ^1.8.1 dev_dependencies: mocktail: ^1.0.0 test: ^1.25.0 - very_good_analysis: ^6.0.0 + very_good_analysis: ^9.0.0 diff --git a/bricks/dart_frog_dev_server/hooks/analysis_options.yaml b/bricks/dart_frog_dev_server/hooks/analysis_options.yaml index c2f4cbbca..141ed91bf 100644 --- a/bricks/dart_frog_dev_server/hooks/analysis_options.yaml +++ b/bricks/dart_frog_dev_server/hooks/analysis_options.yaml @@ -1 +1,5 @@ -include: package:very_good_analysis/analysis_options.7.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml +linter: + rules: + # Experimental and there are lots of false positives + specify_nonobvious_property_types: false \ No newline at end of file diff --git a/bricks/dart_frog_dev_server/hooks/pubspec.yaml b/bricks/dart_frog_dev_server/hooks/pubspec.yaml index d47f4f986..d318ce50c 100644 --- a/bricks/dart_frog_dev_server/hooks/pubspec.yaml +++ b/bricks/dart_frog_dev_server/hooks/pubspec.yaml @@ -6,11 +6,11 @@ environment: dependencies: dart_frog_gen: ^2.0.0 - mason: ^0.1.0-dev.39 + mason: ^0.1.0 pubspec_parse: ^1.2.0 dev_dependencies: mocktail: ^1.0.0 path: ^1.8.2 test: ^1.25.0 - very_good_analysis: ^7.0.0 + very_good_analysis: ^9.0.0 diff --git a/bricks/dart_frog_new/hooks/analysis_options.yaml b/bricks/dart_frog_new/hooks/analysis_options.yaml index 291e0e635..86791dda4 100644 --- a/bricks/dart_frog_new/hooks/analysis_options.yaml +++ b/bricks/dart_frog_new/hooks/analysis_options.yaml @@ -1,5 +1,7 @@ -include: package:very_good_analysis/analysis_options.7.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml linter: rules: public_member_api_docs: false + # Experimental and there are lots of false positives + specify_nonobvious_property_types: false \ No newline at end of file diff --git a/bricks/dart_frog_new/hooks/pubspec.yaml b/bricks/dart_frog_new/hooks/pubspec.yaml index 873731292..668b9bf10 100644 --- a/bricks/dart_frog_new/hooks/pubspec.yaml +++ b/bricks/dart_frog_new/hooks/pubspec.yaml @@ -6,10 +6,10 @@ environment: dependencies: dart_frog_gen: ^2.0.0 - mason: ^0.1.0-dev.49 + mason: ^0.1.0 path: ^1.8.0 dev_dependencies: mocktail: ^1.0.0 test: ^1.19.2 - very_good_analysis: ^7.0.0 + very_good_analysis: ^9.0.0 diff --git a/bricks/dart_frog_prod_server/hooks/analysis_options.yaml b/bricks/dart_frog_prod_server/hooks/analysis_options.yaml index 3a6b5d4c4..90b204453 100644 --- a/bricks/dart_frog_prod_server/hooks/analysis_options.yaml +++ b/bricks/dart_frog_prod_server/hooks/analysis_options.yaml @@ -1,4 +1,6 @@ -include: package:very_good_analysis/analysis_options.6.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml linter: rules: - public_member_api_docs: false + public_member_api_docs: false + # Experimental and there are lots of false positives + specify_nonobvious_property_types: false \ No newline at end of file diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart b/bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart index 69d703367..72d2f8e4c 100644 --- a/bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart +++ b/bricks/dart_frog_prod_server/hooks/lib/src/create_bundle.dart @@ -29,7 +29,7 @@ Future createBundle({ '${tempDirectory.path}${path.separator}', ); bundlingProgress.complete(); - } catch (error) { + } on Exception catch (error) { bundlingProgress.fail(); context.logger.err('$error'); return exit(1); diff --git a/bricks/dart_frog_prod_server/hooks/lib/src/pubspec_lock/pubspec_lock.dart b/bricks/dart_frog_prod_server/hooks/lib/src/pubspec_lock/pubspec_lock.dart index 8e5872bbd..942926e06 100644 --- a/bricks/dart_frog_prod_server/hooks/lib/src/pubspec_lock/pubspec_lock.dart +++ b/bricks/dart_frog_prod_server/hooks/lib/src/pubspec_lock/pubspec_lock.dart @@ -1,10 +1,3 @@ -/// A simple parser for pubspec.lock files. -/// -/// This is used by the bundling process to check for those dependencies that -/// are external path dependencies. Hence, it is not a complete parser, it only -/// parses the information that is needed for the bundling process. -library pubspec_lock; - import 'dart:collection'; import 'package:equatable/equatable.dart'; @@ -35,6 +28,8 @@ class PubspecLock { late final YamlMap yaml; try { yaml = loadYaml(content) as YamlMap; + // ignoring for backward compatibility + // ignore: avoid_catches_without_on_clauses } catch (_) { throw const PubspecLockParseException(); } @@ -53,6 +48,8 @@ class PubspecLock { data: entry.value as YamlMap, ); parsedPackages.add(package); + // ignoring for backward compatibility + // ignore: avoid_catches_without_on_clauses } catch (_) { // Ignore those packages that for some reason cannot be parsed. } diff --git a/bricks/dart_frog_prod_server/hooks/pre_gen.dart b/bricks/dart_frog_prod_server/hooks/pre_gen.dart index 885184151..4e8caf88f 100644 --- a/bricks/dart_frog_prod_server/hooks/pre_gen.dart +++ b/bricks/dart_frog_prod_server/hooks/pre_gen.dart @@ -48,7 +48,7 @@ Future preGen( final RouteConfiguration configuration; try { configuration = buildConfiguration(projectDirectory); - } catch (error) { + } on Exception catch (error) { context.logger.err('$error'); return exit(1); } diff --git a/bricks/dart_frog_prod_server/hooks/pubspec.yaml b/bricks/dart_frog_prod_server/hooks/pubspec.yaml index 6640f4b81..b51f41634 100644 --- a/bricks/dart_frog_prod_server/hooks/pubspec.yaml +++ b/bricks/dart_frog_prod_server/hooks/pubspec.yaml @@ -8,11 +8,11 @@ dependencies: dart_frog_gen: ^2.0.0 equatable: ^2.0.5 io: ^1.0.3 - mason: ^0.1.0-dev.39 + mason: ^0.1.0 path: ^1.8.1 yaml: ^3.1.2 dev_dependencies: mocktail: ^1.0.0 test: ^1.25.0 - very_good_analysis: ^6.0.0 + very_good_analysis: ^9.0.0 diff --git a/bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart b/bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart index db375c594..c78d25653 100644 --- a/bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart +++ b/bricks/dart_frog_prod_server/hooks/test/pubspec_locks.dart @@ -1,6 +1,3 @@ -/// Collection of `pubspec.lock` files used as fixtures during testing. -library pubspec_locks; - /// An artificially crafted `pubspec.lock` file with: /// /// * A transitive dependency. diff --git a/bricks/dart_frog_prod_server/hooks/test/src/pubspec_lock/pubspec_lock_test.dart b/bricks/dart_frog_prod_server/hooks/test/src/pubspec_lock/pubspec_lock_test.dart index f5e59360a..47a9c80f4 100644 --- a/bricks/dart_frog_prod_server/hooks/test/src/pubspec_lock/pubspec_lock_test.dart +++ b/bricks/dart_frog_prod_server/hooks/test/src/pubspec_lock/pubspec_lock_test.dart @@ -1,3 +1,4 @@ +// ignoring for testing purposes // ignore_for_file: prefer_const_constructors import 'package:dart_frog_prod_server_hooks/src/pubspec_lock/pubspec_lock.dart'; diff --git a/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml b/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml index c2f4cbbca..9df80aa49 100644 --- a/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml +++ b/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.7.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml diff --git a/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml b/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml index bf6fcf2c1..72a90f074 100644 --- a/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml +++ b/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml @@ -14,4 +14,4 @@ dependencies: dev_dependencies: mocktail: ^1.0.0 test: ^1.25.0 - very_good_analysis: ^7.0.0 + very_good_analysis: ^9.0.0 diff --git a/examples/todos/packages/todos_data_source/analysis_options.yaml b/examples/todos/packages/todos_data_source/analysis_options.yaml index c2f4cbbca..9df80aa49 100644 --- a/examples/todos/packages/todos_data_source/analysis_options.yaml +++ b/examples/todos/packages/todos_data_source/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.7.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml diff --git a/examples/todos/packages/todos_data_source/pubspec.yaml b/examples/todos/packages/todos_data_source/pubspec.yaml index 7f6d9b41a..719d19489 100644 --- a/examples/todos/packages/todos_data_source/pubspec.yaml +++ b/examples/todos/packages/todos_data_source/pubspec.yaml @@ -16,4 +16,4 @@ dev_dependencies: json_serializable: ^6.3.1 mocktail: ^1.0.0 test: ^1.25.0 - very_good_analysis: ^7.0.0 + very_good_analysis: ^9.0.0 diff --git a/packages/dart_frog_cli/e2e/analysis_options.yaml b/packages/dart_frog_cli/e2e/analysis_options.yaml index c2f4cbbca..9df80aa49 100644 --- a/packages/dart_frog_cli/e2e/analysis_options.yaml +++ b/packages/dart_frog_cli/e2e/analysis_options.yaml @@ -1 +1 @@ -include: package:very_good_analysis/analysis_options.7.0.0.yaml +include: package:very_good_analysis/analysis_options.yaml diff --git a/packages/dart_frog_cli/e2e/pubspec.yaml b/packages/dart_frog_cli/e2e/pubspec.yaml index 954555c5d..c3c28c0fe 100644 --- a/packages/dart_frog_cli/e2e/pubspec.yaml +++ b/packages/dart_frog_cli/e2e/pubspec.yaml @@ -14,4 +14,4 @@ dev_dependencies: meta: ^1.7.0 path: ^1.8.2 test: ^1.19.2 - very_good_analysis: ^7.0.0 + very_good_analysis: ^9.0.0