-
Notifications
You must be signed in to change notification settings - Fork 18
Open
Description
Hello , the following config options do not seem to work as expected.
Issue Summary:
- Files are not displayed when using these two options for
"created"and"createdOrModified" - Code coverage report is correctly displayed when using
"all"
Investigation Results:
- possibly
filterForCoveredFilesis failing to return an array of files - seems like file paths are not in sync for files found with
danger.git.modified_filesvs files fromcoverage
My setup:
-
using
"danger-plugin-istanbul-coverage": "^1.6.2", -
Followed the documentation for this setup https://danger.systems/js/plugins/danger-plugin-istanbul-coverage.html
const coverageConfig = {
coveragePath: {
path: path.resolve(
__dirname,
"...customPath/coverage-summary.json"
),
type: "json-summary"
},
reportMode: "warn",
entrySortMethod: "least-coverage",
reportFileSet: "createdOrModified",
numberOfEntries: 20,
threshold: {
statements: 40,
branches: 40,
functions: 40,
lines: 40
}
};
ThomasGHenry
Metadata
Metadata
Assignees
Labels
No labels