Skip to content

Report file set does not work for "created" or "createdOrModified" groups #56

@pc-mwong

Description

@pc-mwong

Hello , the following config options do not seem to work as expected.

Issue Summary:

  • Files are not displayed when using these two options for "created" and "createdOrModified"
  • Code coverage report is correctly displayed when using "all"

Investigation Results:

  • possibly filterForCoveredFiles is failing to return an array of files
  • seems like file paths are not in sync for files found with danger.git.modified_files vs files from coverage

My setup:

const coverageConfig = {
  coveragePath: {
    path: path.resolve(
      __dirname,
      "...customPath/coverage-summary.json"
    ),
    type: "json-summary"
  },
  reportMode: "warn",
  entrySortMethod: "least-coverage",
  reportFileSet: "createdOrModified",
  numberOfEntries: 20,
  threshold: {
    statements: 40,
    branches: 40,
    functions: 40,
    lines: 40
  }
};

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions