Dev (#282)

* rename

* event source update

* raise exception on post migration if cache not indexed

* rename

* notes update

* remove old interceptors

* some warnings alert tooltips implementation in input fields

* show warnings per field and allow for typesafe adhoc warnings based on formvalue

* notes for warningfn in arrays

* showcase warnings in leaf items and array of objects

* array of objects child update

* xo update

* readme update

Author: danicc097

README.md

@@ -157,9 +157,4 @@ Simplified:
 
 - System design docs/diagrams.
 
-- [Oauth2 as openapi
-  spec](https://github.com/ybelenko/oauth2_as_oas3_components/tree/master/dist/components)
-  with endpoints clearly documented based on RFCs
-  Can generate a mock with e.g.
-  [openapi-mock](https://github.com/muonsoft/openapi-mock).
 

db/migrations/README.md

@@ -1,28 +1,27 @@
-# Schema dumping (obtuse version, do not implement)
-
-**breaks plpgsql lsp extension, would need opt migration names to skip regex option,
-or via flag on top of the file (preferred)**
-
-Eventually, accumulated migrations will take too long to run compared to
-creating the final schema in one go.
-You can create a new migration via `project migrate.create x_schema_dump` (must be named
-x_schema_dump).
-These migration files will be detected before executing `up` migrations.
-
-The latest x_schema_dump migration will be the new reference point for further
-migrations.
-
-If current revision is 0 (i.e. `error: no migration` exit 1),
-it will execute `force $((latest_schema_dump_revision - 1))`
-and then `up` normally. Ideal for tests, gen db, etc.
-
-If current revision is within 1 and `$((latest_schema_dump_revision -1))` (e.g.
-in prod environment)
-it will skip all x_schema_dump migrations in between, executing
-`goto $((schema_dump_revision - 1))` and then `force $schema_dump_revision` in ascending x_schema_dump
-migrations order.
-
-In any other case, it simply runs `up` as usual.
+> # Schema dumping (obtuse version, do not implement)
+> **breaks plpgsql lsp extension, would need opt migration names to skip regex > option,
+> or via flag on top of the file (preferred)**
+>
+> Eventually, accumulated migrations will take too long to run compared to
+> creating the final schema in one go.
+> You can create a new migration via `project migrate.create x_schema_dump` > (must be named
+> x_schema_dump).
+> These migration files will be detected before executing `up` migrations.
+>
+> The latest x_schema_dump migration will be the new reference point for further
+> migrations.
+>
+> If current revision is 0 (i.e. `error: no migration` exit 1),
+> it will execute `force $((latest_schema_dump_revision - 1))`
+> and then `up` normally. Ideal for tests, gen db, etc.
+>
+> If current revision is within 1 and `$((latest_schema_dump_revision -1))` (e.g.
+> in prod environment)
+> it will skip all x_schema_dump migrations in between, executing
+> `goto $((schema_dump_revision - 1))` and then `force $schema_dump_revision` in > ascending x_schema_dump
+> migrations order.
+>
+> In any other case, it simply runs `up` as usual.
 
 
 # Schema dumping (less obtuse version)
@@ -36,9 +35,10 @@ project db.bash
 ```
 
 TODO: all comments will be lost. should instead make use of comments on tables
-instead of sql comments so they're saved after migrating a to a schema dump
+instead of sql comments so they're saved after migrating to a schema dump
 and removing old files. (not like anyone would read old migration files comments
-anyway). Can use `project dev-utils.show-table-comments` to make maintenance easier.
+anyway). Can use `project dev-utils.show-table-comments` to make maintenance
+easier.
 
 Once prod is up to date (i.e. revision at latest_schema_dump_revision minus
 one),

db/post-migrations/003_cache_tables_triggers.up.sql

@@ -126,7 +126,7 @@ end;
 $$
 language plpgsql;
 
-create or replace function create_work_item_cache_table (project_name text)
+create or replace function create_or_update_work_item_cache_table (project_name text)
   returns VOID
   as $$
 declare
@@ -223,7 +223,7 @@ begin
   from
     projects loop
       perform
-        create_work_item_cache_table (project_name);
+        create_or_update_work_item_cache_table (project_name);
 
       idx_name := FORMAT('cache__%I_gin_index' , project_name);
 
@@ -239,7 +239,7 @@ begin
         title extensions.gin_trgm_ops
         )';
       else
-        idx_def := ''; raise notice 'No index definitions for cache__%' , project_name;
+        idx_def := ''; raise exception 'No index definition found for cache__%' , project_name;
       end case;
 
       if idx_def <> '' and not same_index_definition (idx_name , idx_def) then

db/post-migrations/README.md

@@ -1,3 +1,6 @@
 All `*.up.sql` files are always executed like regular migrations after main `migrations`'s `up` regardless of `post-migrations` current
-version. `post-migrations` always applies its down migrations before execution.
+version.
+
+`post-migrations` always applies its down migrations before execution.
+
 Post-migration commands should be idempotent. Do not use `*.down.sql` files.

e2e/client/gen/model/topic.ts

@@ -13,6 +13,7 @@ export type Topic = typeof Topic[keyof typeof Topic]
 
 // eslint-disable-next-line @typescript-eslint/no-redeclare
 export const Topic = {
+  AppDebug: 'AppDebug',
   WorkItemUpdated: 'WorkItemUpdated',
   TeamCreated: 'TeamCreated',
   GlobalAlerts: 'GlobalAlerts',

frontend/src/client-validator/gen/dereferenced-schema.json

@@ -3214,6 +3214,7 @@
         "description": "string identifiers for SSE event listeners.",
         "type": "string",
         "enum": [
+          "AppDebug",
           "WorkItemUpdated",
           "TeamCreated",
           "GlobalAlerts"
@@ -3225,6 +3226,7 @@
       "description": "string identifiers for SSE event listeners.",
       "type": "string",
       "enum": [
+        "AppDebug",
         "WorkItemUpdated",
         "TeamCreated",
         "GlobalAlerts"
@@ -9532,6 +9534,7 @@
         "description": "string identifiers for SSE event listeners.",
         "type": "string",
         "enum": [
+          "AppDebug",
           "WorkItemUpdated",
           "TeamCreated",
           "GlobalAlerts"
@@ -9543,6 +9546,7 @@
       "description": "string identifiers for SSE event listeners.",
       "type": "string",
       "enum": [
+        "AppDebug",
         "WorkItemUpdated",
         "TeamCreated",
         "GlobalAlerts"

frontend/src/client-validator/gen/models.ts

@@ -89,7 +89,7 @@ export type Location1 = string[]
 /**
  * string identifiers for SSE event listeners.
  */
-export type Topic = 'WorkItemUpdated' | 'TeamCreated' | 'GlobalAlerts'
+export type Topic = 'AppDebug' | 'WorkItemUpdated' | 'TeamCreated' | 'GlobalAlerts'
 export type Topics = Topic[]
 export type UuidUUID = string
 export type WorkItem = DemoWorkItem | DemoTwoWorkItem

frontend/src/client-validator/gen/schema.json

@@ -1622,6 +1622,7 @@
       "description": "string identifiers for SSE event listeners.",
       "type": "string",
       "enum": [
+        "AppDebug",
         "WorkItemUpdated",
         "TeamCreated",
         "GlobalAlerts"

frontend/src/components/Callout/DynamicFormErrorCallout.tsx

@@ -42,11 +42,10 @@ export default function DynamicFormErrorCallout() {
   const warnings = calloutWarnings ? entries(calloutWarnings).map(([schemaKey, warning], idx) => warning) : []
   const errors = concat(
     extractCalloutErrors(),
-    entries(rhfErrors).map(([schemaKey, error], idx) => {
+    entries(rhfErrors).map(([schemaKey, error], _) => {
       let message = lowerFirst(error.message) // lowerCase breaks regexes
       schemaKey = schemaKey.replace(/\.\d+$/, '') as SchemaKey // TODO: in flattener instead
 
-      console.log({ schemaKey, error })
       const itemName = options.labels[schemaKey] || ''
 
       if (error.index) {
@@ -58,8 +57,6 @@ export default function DynamicFormErrorCallout() {
         message = `${message} (example: ${randexp(match[1] || '')})`
       }
 
-      console.log({ message })
-
       return `${itemName}: ${message}`
     }),
   )

frontend/src/components/Callout/useCalloutErrors.ts

@@ -56,7 +56,7 @@ export const useCalloutErrors = (formName: string) => {
     return errors
   }
 
-  const extractCalloutTitle = () => {
+  const extractCalloutTitle = (): string => {
     if (Object.keys(form?.customErrors ?? {}).length > 0) {
       return 'Validation error'
     }
@@ -79,13 +79,14 @@ export const useCalloutErrors = (formName: string) => {
           case 'Unauthorized':
             return 'Unauthorized'
           case 'Unknown':
+            return unknownError
           default:
             return calloutError.message
         }
       }
 
       // external call error
-      if (calloutErrors instanceof AxiosError) return calloutError
+      if (calloutError instanceof AxiosError) return calloutError.message
     }
 
     // errors unrelated to api calls and validation