Skip to content

Commit 9fb7388

Browse files
committed
remove old comments
1 parent 5b1b6c8 commit 9fb7388

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

.golangci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ run:
77
linters:
88
enable-all: true
99
disable:
10+
- nlreturn
11+
- mnd
1012
- dupword
1113
- ireturn # oapi-codegen strict handlers
1214
# - interfacebloat

internal/rest/api.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const (
1919
AuthorizationHeaderKey = "authorization"
2020
)
2121

22+
// StrictHandlers implements StrictServerInterface.
2223
type StrictHandlers struct {
2324
svc *services.Services
2425

@@ -31,13 +32,6 @@ type StrictHandlers struct {
3132
provider rp.RelyingParty
3233
}
3334

34-
// IMPORTANT: oapi codegen uses its own types for responses and request bodies,
35-
// and we absolutely do not want this, since we would need to manually convert
36-
// to or from oapi's Rest<..> and Db<..> structs.
37-
// is it worth it to rewrite strict server gen to use rest package structs for request/response bodies?
38-
// we could check in templates with a simple if stmt
39-
// that if a type in rest package exists with the same name we don't prepend `externalRef0.`
40-
// We already have the rest pkg struct list from ast-parser gen.
4135
var _ StrictServerInterface = (*StrictHandlers)(nil)
4236

4337
// NewStrictHandlers returns a server implementation of an openapi specification.

0 commit comments

Comments
 (0)