Dev (#356)

* river postgres queue note

* gitignore

* xo sql properties validation

Author: danicc097

.gitignore

@@ -1,3 +1,4 @@
+**/repopack-output.*
 **/.vite
 .direnv
 db/schema.sql

db/migrations/0000002_init.up.sql

@@ -304,7 +304,7 @@ create table users (
   , foreign key (api_key_id) references user_api_keys (user_api_key_id) on delete cascade
 );
 
-comment on column users.external_id is '"properties":private,something-else';
+comment on column users.external_id is '"properties":private';
 
 comment on column users.api_key_id is '"properties":private';
 

internal/repos/postgresql/xo-templates/go.go

@@ -97,6 +97,17 @@ const (
 	// example: "properties":private,another-property && "type":ProjectName && "tags":pattern: ^[\.a-zA-Z0-9_-]+$
 )
 
+func allProperties() []string {
+	return []string{
+		propertiesJoinOperator,
+		propertyRefsIgnore,
+		propertyShareRefConstraints,
+		propertyJSONPrivate,
+		propertyOpenAPINotRequired,
+		propertyOpenAPIHidden,
+	}
+}
+
 // to not have to analyze everything for convertConstraints
 var cardinalityRE = regexp.MustCompile(string(cardinalityAnnot) + annotationAssignmentOperator + "([A-Za-z0-9_-]*)")
 
@@ -1571,7 +1582,14 @@ func convertField(ctx context.Context, tf transformFunc, f xo.Field) (Field, err
 func extractPropertiesAnnotation(annotation annotation) []string {
 	var properties []string
 	for _, p := range strings.Split(annotation, propertiesJoinOperator) {
-		properties = append(properties, strings.TrimSpace(strings.ToLower(p)))
+		prop := strings.TrimSpace(strings.ToLower(p))
+		if prop == "" {
+			continue
+		}
+		if !contains(allProperties(), prop) {
+			panic(fmt.Sprintf("unknown sql comment property: %s", prop))
+		}
+		properties = append(properties, prop)
 	}
 
 	return properties

internal/tasks/TODO.md

@@ -1,3 +1,5 @@
-- checkout https://github.com/hibiken/asynq
+- checkout https://github.com/hibiken/asynq (not recommended)
+- https://github.com/riverqueue/river 🆗 (postgres under the hood - made to share same db)
+
 - NATS jetstream
 - rabbitmq