fix fieldcollection assignment, see #375 (#376)

solverat · web-flow · commit fb3059a38c09 · 2023-01-23T17:21:23.000+01:00
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,5 +1,8 @@
 # Upgrade Notes
 
+## Version 4.3.1
+- **[BUGFIX]**: Fix field collection assignment [#375](https://github.com/dachcom-digital/pimcore-formbuilder/issues/375)
+
 ## Version 4.3.0
 - **[ENHANCEMENT]**: Use Flysystem for Storage [#334](https://github.com/dachcom-digital/pimcore-formbuilder/issues/334)
   - Remove `PIMCORE_SYSTEM_TEMP_DIRECTORY/formbuilder-cache` as it is no longer needed
diff --git a/src/FormBuilderBundle/OutputWorkflow/Channel/Object/AbstractObjectResolver.php b/src/FormBuilderBundle/OutputWorkflow/Channel/Object/AbstractObjectResolver.php
@@ -268,7 +268,7 @@ protected function appendToFieldCollection(DataObject\Concrete $object, string $
                 $fieldDefinition = $this->findMapDefinition($fieldMapping, $fieldName);
 
                 if ($fieldDefinition === false) {
-                    return;
+                    continue;
                 }
 
                 $this->assignChildDataToObject($fieldCollection, $fieldDefinition, $fieldValue);

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ protected function appendToFieldCollection(DataObject\Concrete $object, string $`
`268`	`268`	`$fieldDefinition = $this->findMapDefinition($fieldMapping, $fieldName);`
`269`	`269`
`270`	`270`	`if ($fieldDefinition === false) {`
`271`		`- return;`
	`271`	`+ continue;`
`272`	`272`	`}`
`273`	`273`
`274`	`274`	`$this->assignChildDataToObject($fieldCollection, $fieldDefinition, $fieldValue);`