solidify check for empty value in output transformer, fixes #486 (#513)

Author: solverat

UPGRADE.md

@@ -2,6 +2,7 @@
 
 ## 5.3.0
 - **[IMPROVEMENT]** New field added to `form_builder_form_attributes`: `autocomplete`
+- **[BUGFIX]** Solidify check for empty value in output transformer [#486](https://github.com/dachcom-digital/pimcore-formbuilder/issues/508)
 
 ## 5.2.0
 - **[LICENSE]** Dual-License with GPL and Dachcom Commercial License (DCL) added

src/Transformer/Output/FallbackTransformer.php

@@ -70,7 +70,7 @@ protected function parseDynamicField(FormFieldDynamicDefinitionInterface $field,
 
     protected function parseDefaultField(mixed $value, FormInterface $formField, ?string $locale): mixed
     {
-        if (empty($value)) {
+        if ($value === null || $value === '') {
             return $value;
         }
 
@@ -164,15 +164,15 @@ protected function parseDynamicLabel(FormFieldDynamicDefinitionInterface $field,
         $label = $formField->getConfig()->hasOption('label') ? $formField->getConfig()->getOption('label') : $field->getName();
         $optionalOptions = $field->getOptional();
 
-        $emailLabel = isset($optionalOptions['email_label']) && !empty($optionalOptions['email_label'])
+        $emailLabel = !empty($optionalOptions['email_label'])
             ? $this->translator->trans($optionalOptions['email_label'], [], null, $locale)
             : null;
 
         if (!empty($emailLabel)) {
             return $emailLabel;
         }
 
-        return isset($label) && !empty($label)
+        return !empty($label)
             ? $this->translator->trans($label, [], null, $locale)
             : $label;
     }
@@ -186,15 +186,15 @@ protected function parseDefaultLabel(FieldDefinitionInterface $field, ?string $l
         $fieldOptions = $field->getOptions();
         $optionalOptions = $field->getOptional();
 
-        $emailLabel = isset($optionalOptions['email_label']) && !empty($optionalOptions['email_label'])
+        $emailLabel = !empty($optionalOptions['email_label'])
             ? $this->translator->trans($optionalOptions['email_label'], [], null, $locale)
             : null;
 
         if (!empty($emailLabel)) {
             return $emailLabel;
         }
 
-        return isset($fieldOptions['label']) && !empty($fieldOptions['label'])
+        return !empty($fieldOptions['label'])
             ? $this->translator->trans($fieldOptions['label'], [], null, $locale)
             : $field->getName();
     }