add role attribute to honeypot field (#339)

Author: solverat

UPGRADE.md

@@ -1,7 +1,8 @@
 # Upgrade Notes
 
-#### Update to Version 4.1.2
+## Version 4.1.2
 - **[BUGFIX]**: Email CSV export: delete unnecessary line to prevent out of memory issues. [#328](https://github.com/dachcom-digital/pimcore-formbuilder/pull/328)
+- **[ENHANCEMENT]**: Add `role="presentation"` to honeypot. [#333](https://github.com/dachcom-digital/pimcore-formbuilder/issues/333)
 
 ## Version 4.1.1
 - **[BUGFIX]**: Fix legacy fine uploader identifier

docs/03_SpamProtection.md

@@ -8,7 +8,8 @@ form_builder:
     spam_protection:
         honeypot:
             field_name: 'inputUserName'     # this is the default value
-            enable_inline_style: true       # ths is the default value
+            enable_inline_style: true       # this is the default value
+            enable_role_attribute: true     # this is the default value and will add the role="presentation" attribute
 ```
 
 ***

src/FormBuilderBundle/DependencyInjection/Configuration.php

@@ -605,6 +605,7 @@ private function buildSpamProductionNode(): NodeDefinition
                     ->children()
                         ->scalarNode('field_name')->defaultValue('inputUserName')->end()
                         ->booleanNode('enable_inline_style')->defaultTrue()->end()
+                        ->booleanNode('enable_role_attribute')->defaultTrue()->end()
                     ->end()
                 ->end()
                 ->arrayNode('recaptcha_v3')

src/FormBuilderBundle/Form/Type/HoneypotType.php

@@ -23,15 +23,21 @@ public function configureOptions(OptionsResolver $resolver): void
         $config = $this->configuration->getConfig('spam_protection');
         $honeyPotConfig = $config['honeypot'];
 
+        $attributes = [
+            'autocomplete' => 'off',
+            'tabindex'     => -1,
+            'style'        => $honeyPotConfig['enable_inline_style'] === true ? 'position: absolute; left: -500%; top: -500%;' : ''
+        ];
+
+        if ($honeyPotConfig['enable_role_attribute'] === true) {
+            $attributes['role'] = 'presentation';
+        }
+
         $resolver->setDefaults([
             'required'       => false,
             'mapped'         => false,
             'data'           => '',
-            'attr'           => [
-                'autocomplete' => 'off',
-                'tabindex'     => -1,
-                'style'        => $honeyPotConfig['enable_inline_style'] === true ? 'position: absolute; left: -500%; top: -500%;' : ''
-            ],
+            'attr'           => $attributes,
             'constraints'    => [
                 new Blank(
                     [