Skip to content

CreateFetch optional query param types incorrect #21

@ricky-bok-privitar

Description

@ricky-bok-privitar

Hi,

Thanks so much for maintaining this library! I've a question, given some optional parameters in the query, the types in the parameters seem to be incorrect:

Given the following types:

createX: {
    parameters: {
      query: {
        includeTags?: true | false;
      };      

When we try to create the fetch command, we are forced to include the parameters, but with no option to turn it off:

fetcher
    .path('/api/v1/x')
    .method('post')     
    .create({
      includeTags: true, // The type is true | 1, when it should be a boolean
    })

Is this an issue, or am I not using this correctly? Thanks for your input!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions