Skip to content

Commit 8e3c0bf

Browse files
authored
make sidekiq UI modifiable & Be rijbewijs improvements (#956)
* intial commit * make BE rijbewijs exportable * improved implementation * added setupcomplete to export variables
1 parent ecd9918 commit 8e3c0bf

File tree

7 files changed

+39
-22
lines changed

7 files changed

+39
-22
lines changed

app/components/cards/privacy-preference.hbs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,5 @@
4949
<td>Gegevens (naam, afbeelding, studie) mogen gedeeld worden in de almanak</td>
5050
<td data-test-info-in-almanak>{{boolean-tag @model.infoInAlmanak}}</td>
5151
</tr>
52-
<tr>
53-
<td>Bezit BE rijbewijs</td>
54-
<td data-test-trailer-drivers-license>{{boolean-tag @model.trailerDriversLicense}}</td>
55-
</tr>
5652
</tbody>
5753
</table>

app/components/forms/user-form.hbs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,13 @@
142142
@labelClass='col-sm-5'
143143
@inputWrapperClass='col-sm-7'
144144
/>
145+
<ModelForm::CheckboxInput
146+
@model={{@model}}
147+
@property='trailerDriversLicense'
148+
@label='BE rijbewijs'
149+
@labelClass='col-sm-5'
150+
@inputWrapperClass='col-sm-7'
151+
/>
145152

146153
<h5>Voorkeuren</h5>
147154
<ModelForm::SelectInput
@@ -172,6 +179,16 @@
172179
@labelColspan={{5}}
173180
/>
174181

182+
<ModelForm::CheckboxInput
183+
@model={{@model}}
184+
@property='sidekiqAccess'
185+
@labelClass='col-sm-5'
186+
@inputWrapperClass='col-sm-7'
187+
@label='Sidekiq toegang'
188+
@disabled={{@canEditOnlyOwnProperties}}
189+
@labelColspan={{5}}
190+
/>
191+
175192
<ModelForm::FormActions
176193
@errors={{@model.errors}}
177194
@errorMessage={{@errorMessage}}

app/components/users/privacy-settings.hbs

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -87,21 +87,6 @@
8787
</div>
8888
</div>
8989

90-
<div class='mb-3 row align-items-center'>
91-
<label class='col-10 col-sm-6 col-form-label form-label' for="trailer-drivers-license-check">
92-
Bezit BE rijbewijs
93-
</label>
94-
<div class='col-2 col-sm-6'>
95-
{{input
96-
data-test-trailerDriversLicense=true
97-
type='checkbox'
98-
checked=@model.trailerDriversLicense
99-
class='form-check-input'
100-
id="trailer-drivers-license-check"
101-
}}
102-
</div>
103-
</div>
104-
10590
{{#if formActionsVisible}}
10691
<ModelForm::FormActions
10792
@errors={{@model.errors}}

app/controllers/groups/group/export.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,14 @@ export default class GroupExportController extends Controller {
115115
value: 'emergency_number',
116116
label: 'Noodnummer',
117117
},
118+
{
119+
value: 'trailerDriversLicense',
120+
label: 'BE rijbewijs',
121+
},
122+
{
123+
value: 'setupComplete',
124+
label: 'Setup voltooid',
125+
},
118126
];
119127

120128
@computed('questions.@each.answer')

app/models/user.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,21 +26,22 @@ export default class User extends Model {
2626
// Preferences / settings
2727
@attr foodPreferences;
2828
@attr vegetarian;
29+
@attr trailerDriversLicense;
2930
@attr('date-only') startStudy;
31+
32+
// Restricted Settings
3033
@attr emergencyContact;
3134
@attr emergencyNumber;
3235
@attr almanakSubscriptionPreference;
3336
@attr digtusSubscriptionPreference;
3437

3538
// Privacy settings
3639
@attr picturePublicationPreference;
37-
3840
@attr ifesDataSharingPreference;
3941
@attr allowTomatoSharing;
4042
@attr infoInAlmanak;
4143
@attr userDetailsSharingPreference;
42-
@attr trailerDriversLicense;
43-
@attr setupComplete;
44+
4445
// Security properties
4546
@attr otpRequired;
4647
@attr icalSecretKey;
@@ -51,6 +52,8 @@ export default class User extends Model {
5152
@attr('date') activatedAt;
5253
@attr('date') createdAt;
5354
@attr('date') updatedAt;
55+
@attr sidekiqAccess;
56+
@attr setupComplete;
5457

5558
// Avatar
5659
@attr avatar;

app/templates/users/user/index.hbs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,10 @@
8181
}}
8282
</td>
8383
</tr>
84+
<tr>
85+
<td>Bezit BE rijbewijs</td>
86+
<td data-test-trailer-drivers-license>{{boolean-tag @model.trailerDriversLicense}}</td>
87+
</tr>
8488
</tbody>
8589
</table>
8690
</p>

app/templates/users/user/settings.hbs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,10 @@
8484
<td>Two-Factor geactiveerd</td>
8585
<td data-test-otpRequired>{{boolean-tag @model.otpRequired}}</td>
8686
</tr>
87+
<tr>
88+
<td>Sidekiq toegang</td>
89+
<td data-test-sidekiqAccess>{{boolean-tag @model.sidekiqAccess}}</td>
90+
</tr>
8791
</tbody>
8892
</table>
8993
</TabbedView>

0 commit comments

Comments
 (0)