Skip to content

Commit 475d097

Browse files
committed
Added missing comments + deleted redundant variable
1 parent 1b8ba50 commit 475d097

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

include/syropod_highlevel_controller/pose.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
1515
/// Class defining a 3d position and rotation using Eigen Vector3 and Quaternion classes.
1616
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
17+
class Pose
1718
{
1819
public:
1920
/// Blank contructor

include/syropod_highlevel_controller/walk_controller.h

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -417,9 +417,6 @@ class LegStepper
417417
/// @param[in] at_correct_phase The new value for the flag
418418
inline void setAtCorrectPhase(const bool& at_correct_phase) { at_correct_phase_ = at_correct_phase; };
419419

420-
/// TBD
421-
inline void setNewStepFrequency(void) { new_step_frequency_ = true; };
422-
423420
/// Modifier for the flag denoting touchdown detection enabled.
424421
/// @param[in] touchdown_detection The new value for the flag
425422
inline void setTouchdownDetection(const bool& touchdown_detection) { touchdown_detection_ = touchdown_detection; };
@@ -489,10 +486,9 @@ class LegStepper
489486
int phase_ = 0; ///< Step cycle phase
490487
int phase_offset_; ///< Step cycle phase offset
491488

492-
bool new_step_frequency_ = false;
493-
double step_progress_ = 0.0;
494-
double swing_progress_ = -1.0; ///< The progress of the swing period in the step cycle. (0.0->1.0 || -1.0)
495-
double stance_progress_ = -1.0; ///< The progress of the stance period in the step cycle. (0.0->1.0 || -1.0)
489+
double step_progress_ = 0.0; ///< The progress of the entire step cycle (0.0->1.0 || -1.0)
490+
double swing_progress_ = -1.0; ///< The progress of the swing period in the step cycle. (0.0->1.0 || -1.0)
491+
double stance_progress_ = -1.0; ///< The progress of the stance period in the step cycle. (0.0->1.0 || -1.0)
496492

497493
StepState step_state_ = STANCE; ///< The state of the step cycle
498494

@@ -529,4 +525,4 @@ class LegStepper
529525

530526
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
531527

532-
#endif // SYROPOD_HIGHLEVEL_CONTROLLER_WALK_CONTROLLER_H
528+
#endif // SYROPOD_HIGHLEVEL_CONTROLLER_WALK_CONTROLLER_H

src/walk_controller.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ void WalkController::updateManual(const int& primary_leg_selection_ID, const Vec
690690
}
691691
}
692692

693-
Ref: https://math.stackexchange.com/questions/99299/best-fitting-plane-given-a-set-of-points
693+
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
694694

695695
void WalkController::updateWalkPlane(void)
696696
{
@@ -785,7 +785,6 @@ LegStepper::LegStepper(shared_ptr<LegStepper> leg_stepper)
785785
completed_first_step_ = leg_stepper->completed_first_step_;
786786
phase_ = leg_stepper->phase_;
787787
phase_offset_ = leg_stepper->phase_offset_;
788-
new_step_frequency_ = leg_stepper->new_step_frequency_;
789788
stance_progress_ = leg_stepper->stance_progress_;
790789
swing_progress_ = leg_stepper->swing_progress_;
791790
stance_progress_ = leg_stepper->stance_progress_;
@@ -1271,4 +1270,4 @@ void LegStepper::forceNormalTouchdown(void)
12711270
swing_2_nodes_[1] = swing_2_nodes_[0] + (swing_2_nodes_[2] - bezier_origin)/2.0;
12721271
}
12731272

1274-
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////
1273+
////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

0 commit comments

Comments
 (0)