Merge pull request #17 from contentstack/bugfix/DX-780

DX - 780 - Semgrep issues resolved and version bump

Author: cs-raj

.github/workflows/release.yml

@@ -0,0 +1,51 @@
+name: Release
+on:
+  push:
+    branches:
+      - master
+jobs:
+  build:
+    name: Build and upload
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3.5.3
+        with:
+          fetch-depth: 0
+      - name: Setup Node.js
+        uses: actions/setup-node@v3.7.0
+        with:
+          node-version: "18.x"
+      - name: Install dependencies
+        run: npm install
+      - name: Upload dist
+        uses: actions/upload-artifact@v3.1.2
+        with:
+          name: lib
+          path: lib
+
+  release:
+    name: Download dist and release
+    runs-on: ubuntu-latest
+    needs: build
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3.5.3
+        with:
+          fetch-depth: 0
+      - name: Download dist
+        uses: actions/download-artifact@v3
+        with:
+          name: lib
+          path: lib
+      - name: Display directories
+        run: ls -R lib
+      - name: Publish to npm
+        id: release-plugin
+        uses: JS-DevTools/npm-publish@v2.2.0
+        with:
+          token: ${{ secrets.NPM_TOKEN }}
+      - name: Create GitHub release
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: gh release create v${{ steps.release-plugin.outputs.version }} --title "Release ${{ steps.release-plugin.outputs.version }}" --generate-notes

.gitignore

@@ -1,2 +1 @@
 node_modules
-package-lock.json

LICENSE.txt LICENSELICENSE.txt renamed to LICENSE

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Contentstack
+Copyright (c) 2024 Contentstack
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

SECURITY.md

@@ -0,0 +1,27 @@
+## Security
+
+Contentstack takes the security of our software products and services seriously, which includes all source code repositories managed through our GitHub organizations.
+
+If you believe you have found a security vulnerability in any Contentstack-owned repository, please report it to us as described below.
+
+## Reporting Security Issues
+
+**Please do not report security vulnerabilities through public GitHub issues.**
+
+Send email to [security@contentstack.com](mailto:security@contentstack.com).
+
+You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message.
+
+Please include the requested information listed below (as much as you can provide) to help us better understand the nature and scope of the possible issue:
+
+- Type of issue (e.g. buffer overflow, SQL injection, cross-site scripting, etc.)
+- Full paths of source file(s) related to the manifestation of the issue
+- The location of the affected source code (tag/branch/commit or direct URL)
+- Any special configuration required to reproduce the issue
+- Step-by-step instructions to reproduce the issue
+- Proof-of-concept or exploit code (if possible)
+- Impact of the issue, including how an attacker might exploit the issue
+
+This information will help us triage your report more quickly.
+
+[https://www.contentstack.com/trust/](https://www.contentstack.com/trust/)

lib/helper.js

@@ -16,6 +16,7 @@ var prompt = require('prompt');
 var ncp = require('ncp').ncp;
 var mkdirp = require('mkdirp');
 var chalk = require('chalk');
+const sanitizePath = require('./utility');
 var log = console.log;
 var success = chalk.green;
 var error = chalk.red;
@@ -119,7 +120,7 @@ exports.confirm = function(config, lang, backup, callback) {
 exports.createBackupDir = function(storagePath, lang, callback) {
   log(info('Creating backup...'));
   var d = new Date();
-  ncp(path.join(storagePath, lang), path.join(storagePath, lang, '..', `${d.getTime()}_${lang}_backup`), function(err) {
+  ncp(path.join(sanitizePath(storagePath), sanitizePath(lang)), path.join(sanitizePath(storagePath), sanitizePath(lang), '..', `${d.getTime()}_${sanitizePath(lang)}_backup`), function(err) {
     if (err) {
       log(error(
         `Failed to create backup, due to the following error\n${err.message || err}`

lib/plugin.js

@@ -20,18 +20,19 @@ var error = chalk.red;
 var info = chalk.cyan;
 
 var helper = require('./helper');
+const sanitizePath = require('./utility');
 
 /**
  * Create contentstack-express framework plugin
  */
 var Plugin = function(name) {
   try {
-    var dir = path.join(process.cwd(), 'plugins');
+    var dir = path.join(sanitizePath(process.cwd()), 'plugins');
     var match = (name && typeof name == 'string') ? name.match(/^[a-zA-Z0-9\-_]+$/g) : null;
     if (match && match.length) {
       name = name.trim().toLowerCase();
       if (fs.existsSync(dir)) {
-        var _path = path.join(dir, name);
+        var _path = path.join(sanitizePath(dir), sanitizePath(name));
         log(info(`Creating Contentstack plugin at ${_path}`));
         prompt.message = '';
         prompt.delimiter = '>';

lib/request.js

@@ -48,6 +48,10 @@ var makeCall = module.exports = function(req, cb, RETRY) {
       return cb(new Error('Max retry limit exceeded!'));
     }
     debug(`Requesting API\n${JSON.stringify(req, null, 2)}`);
+    //NOTE: Please delete the below three lines in case the code breaks :)
+    let tempObj = Object.create(null);
+    merge(tempObj,req);
+    req = tempObj;
     return request(req, function(err, response, body) {
       if (err) {
         return cb(err);

lib/utility.js

@@ -0,0 +1,5 @@
+const sanitizePath = function (str) {
+  return str?.replace(/^(\.\.(\/|\\|$))+/, "");
+};
+
+module.exports = sanitizePath