refactor(test): toolset tests act as snapshot tests #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
manusa
approved these changes
Nov 27, 2025
Member
manusa
left a comment
manusa
left a comment
There was a problem hiding this comment.
This is great, thanks!!!
I think it really is a problem for toolset implementers or any other contributor who isn't familiar with the repo to update the toolset definitions, this will make their experience much easier.
In the same line, we should probably add some documentation or guide specific to toolset implementors. Describing the architecture, patterns, available tools, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables running the toolset tests in the mcp package as snapshot tests.
IMO, this makes it a lot easier to maintain the JSON files in these tests, especially for newer contributors.
@manusa if you think that another approach makes more sense, happy to discuss/change my approach here