-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Update contract changes for KIP-848 regex subscription #5251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pranavrth
wants to merge
1
commit into
master
Choose a base branch
from
dev_kip848_regex-contract-change-update-doc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -82,6 +82,7 @@ librdkafka also provides a native C++ interface. | |||||
| - [Contract Changes](#contract-changes) | ||||||
| - [Client Configuration changes](#client-configuration-changes) | ||||||
| - [Rebalance Callback Changes](#rebalance-callback-changes) | ||||||
| - [Regex Subscription Changes](#regex-subscription-changes) | ||||||
| - [Static Group Membership](#static-group-membership) | ||||||
| - [Session Timeout \& Fetching](#session-timeout--fetching) | ||||||
| - [Closing / Auto-Commit](#closing--auto-commit) | ||||||
|
|
@@ -1744,6 +1745,16 @@ All [KIP-848](https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+N | |||||
|
|
||||||
| **Note:** The properties listed under “Classic Protocol (Deprecated Configs in KIP-848)” are **no longer used** when using the KIP-848 consumer protocol. | ||||||
|
|
||||||
| <a name="regex-subscription-changes"></a> | ||||||
| ##### Regex Subscription Changes | ||||||
|
|
||||||
| Regex matching in the `consumer` protocol is performed on the broker side, using the **Google RE2/J** regex engine. | ||||||
| This differs from the `classic` protocol—where librdkafka and derived clients performed regex evaluation locally using the **libc regex** engine. | ||||||
|
|
||||||
| As part of adopting the `consumer` protocol, librdkafka (and derived clients) now rely on the broker’s RE2/J engine for regex-based subscriptions, effectively replacing the previous `libc`-based matching behavior. | ||||||
|
|
||||||
| Known case which would fail with the new protocol - We have `topic-1` and `topic-2`. If we subscribe with `^topic*` in the `classic` protocol, it works but it won't work in the `consumer` protocol. Use `^topic.*` instead. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| <a name="rebalance-callback-changes"></a> | ||||||
| ##### Rebalance Callback Changes | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The sentence structure is unclear and could be improved for better readability. Consider rephrasing to: 'A known incompatibility case: Given topics
topic-1andtopic-2, the pattern^topic*works in theclassicprotocol but fails in theconsumerprotocol. Use^topic.*instead.'