improve handleOverlay styling and layout

Author: mikhailChelbaev

Sources/ComponentsKit/Components/Slider/Models/SliderVM.swift

@@ -156,6 +156,15 @@ extension SliderVM {
 // MARK: - UIKit Helpers
 
 extension SliderVM {
+  var isHandleOverlayVisible: Bool {
+    switch self.size {
+    case .small, .medium:
+      return false
+    case .large:
+      return true
+    }
+  }
+
   func stripesBezierPath(in rect: CGRect) -> UIBezierPath {
     return UIBezierPath(cgPath: self.stripesCGPath(in: rect))
   }

Sources/ComponentsKit/Components/Slider/UKSlider.swift

@@ -46,7 +46,6 @@ open class UKSlider: UIView, UKComponent {
   private var barViewConstraints = LayoutConstraints()
   private var backgroundViewConstraints = LayoutConstraints()
   private var handleViewConstraints = LayoutConstraints()
-  private var handleOverlayViewConstraints = LayoutConstraints()
 
   // MARK: - Private Properties
 
@@ -121,9 +120,6 @@ open class UKSlider: UIView, UKComponent {
       self.handleViewConstraints.height?.constant = self.model.handleSize.height
       self.handleViewConstraints.width?.constant = self.model.handleSize.width
 
-      self.handleOverlayViewConstraints.height?.constant = self.model.handleOverlaySide
-      self.handleOverlayViewConstraints.width?.constant = self.model.handleOverlaySide
-
       UIView.performWithoutAnimation {
         self.layoutIfNeeded()
       }
@@ -168,13 +164,11 @@ open class UKSlider: UIView, UKComponent {
       self.handleView.centerVertically()
     }
 
-    self.handleOverlayViewConstraints = .merged {
-      self.handleOverlayView.center()
-      self.handleOverlayView.size(
-        width: self.model.handleOverlaySide,
-        height: self.model.handleOverlaySide
-      )
-    }
+    self.handleOverlayView.center()
+    self.handleOverlayView.size(
+      width: self.model.handleOverlaySide,
+      height: self.model.handleOverlaySide
+    )
   }
 
   open override func layoutSubviews() {
@@ -189,6 +183,9 @@ open class UKSlider: UIView, UKComponent {
     self.handleView.layer.cornerRadius =
     self.model.cornerRadius(for: self.handleView.bounds.width)
 
+    self.handleOverlayView.layer.cornerRadius =
+    self.model.cornerRadius(for: self.handleOverlayView.bounds.width)
+
     self.updateSliderAppearance()
     self.model.validateMinMaxValues()
   }
@@ -282,13 +279,9 @@ extension UKSlider {
     }
 
     static func handleOverlayView(_ view: UIView, model: SliderVM) {
-      if model.size == .large {
-        view.isHidden = false
-        view.backgroundColor = model.color.contrast.uiColor
-        view.layer.cornerRadius = model.cornerRadius(for: model.handleOverlaySide)
-      } else {
-        view.isHidden = true
-      }
+      view.isVisible = model.isHandleOverlayVisible
+      view.backgroundColor = model.color.contrast.uiColor
+      view.layer.cornerRadius = model.cornerRadius(for: model.handleOverlaySide)
     }
   }
 }